gravitational / teleport

The easiest, and most secure way to access and protect all of your infrastructure.
https://goteleport.com
GNU Affero General Public License v3.0
17.42k stars 1.74k forks source link

Migrate from aws-sdk-go to aws-sdk-go-v2 #14142

Open lxea opened 2 years ago

lxea commented 2 years ago

Both versions are currently used in teleport (join_ec2.go,lib/utils/ec2.go use v2), V1 should be migrated away from eventually

Docs for migration: https://aws.github.io/aws-sdk-go-v2/docs/migrating/

greedy52 commented 4 months ago

FYI, we use v1 interface for mocking in testing and we do common error casting using v1 types. Migrating DB access and discovery to aws-sdk-go-v2 requires great effort.

zmb3 commented 4 months ago

Acknowledged. We're going to need to do it anyway as v1 is going end of life and we have unnecessary binary bloat due to using both.