tsh touchid diag not in tsh help

gravitational / teleport

The easiest, and most secure way to access and protect all of your infrastructure.

https://goteleport.com

GNU Affero General Public License v3.0

17.69k stars 1.77k forks source link

tsh touchid diag not in tsh help #18166

Closed stevenGravy closed 2 years ago

stevenGravy commented 2 years ago

Expected behavior:

Commands like touchid and touchid diag are available within tsh help

Current behavior:

tsh help does not show touchid and tsh help touchid does not show that diag is another command.

Bug details:

Teleport version: 11.01
Recreation steps

tsh help tsh help touchid

codingllama commented 2 years ago

Discussed a bit outside of GitHub: not showing on help was intentional, as tsh touchid diag is essentially a debug command (and not something most users should be concerned about). I'm happy to change it so tsh help touchid does display diag, but at first would still keep it hidden from tsh help. I would keep additional support commands hidden too, at least for now.

Happy to revisit if folks think otherwise.

codingllama commented 2 years ago

As it turns out, if we make tsh touchid diag visible, then it shows up on tsh help too. I don't think that's worth it.

Do you mind if we close the issue, @stevenGravy?

stevenGravy commented 2 years ago

Not planned due to the interaction of the tsh help required.