Support labels in "add application" magic link

gravitational / teleport

The easiest, and most secure way to access and protect all of your infrastructure.

https://goteleport.com

GNU Affero General Public License v3.0

17.02k stars 1.71k forks source link

Support labels in "add application" magic link #23096

Open r0mant opened 1 year ago

r0mant commented 1 year ago

Users would like to be able to provide labels in the application install link:

sudo bash -c "$(curl -fsSL 'https://example.com/scripts/<key>/install-app.sh?name=test&uri=https%3A%2F%2Flocalhost%3A443')"

The install script itself supports labels but they can't be passed via this API.

r0mant commented 1 year ago

@ryanclark @marcoandredinis Just FYI. We can probably include this when we're updating Teleport Discover flow for applications (maybe in Q2?)

marcoandredinis commented 1 year ago

We can also re-use the SuggestedLabels prop of the Token.

It would work like this:

user enters the labels they want (we must limit labels count and label size)
a new token is created which includes the SuggestedLabels
when the script is generated, it includes those labels as part of the teleport.yaml config

It currently works for Nodes and only a server side generated Label is present (teleport.dev/resource-id). However, I think this is something we should converge.