gravitational / teleport

The easiest, and most secure way to access and protect all of your infrastructure.
https://goteleport.com
GNU Affero General Public License v3.0
17.04k stars 1.71k forks source link

Joining an active CLI session from Web UI messes with the CLI output #42625

Open pschisa opened 1 month ago

pschisa commented 1 month ago

Expected behavior: Joining an active session as an observer will not impact the active session for the user

Current behavior: When running commands like top on the CLI, if a web UI user joins the session as an observer the output in the CLI is affected and becomes unreadable. This is fixed if the CLI terminal is resized.

https://github.com/gravitational/teleport/assets/75806143/84a81a42-1a55-412e-8d29-b612983f6a98

Bug details:

zmb3 commented 1 month ago

Maybe the flakiness in TestResizeTerminal is pointing at a real issue..

The observer who joins should not be sending a resize sequence, but it looks like they are.