gravitational / teleport

The easiest, and most secure way to access and protect all of your infrastructure.
https://goteleport.com
GNU Affero General Public License v3.0
16.93k stars 1.7k forks source link

Web: Table Updates #43156

Closed kimlisa closed 1 day ago

kimlisa commented 1 week ago

part of https://github.com/gravitational/teleport.e/issues/3571

Previously, client paginated tables current page reset to 0, when doing actions like adding, deleting, or selecting a row. it now only resets to 0 when user is searching or sorting, otherwise preserves current page.

Other changes:

Unified resource search bar is only slightly reduced (same height with document nodes listing):

image

Everywhere else, the search bar is visibly reduced and centered with pager:

client paging (only top pager since data len is < 5)

image

client paging (shows both top and bottom since data len > 5)

image

server side paging (a bottom pager is also rendered but list too big for screenshot)

image

demo of preserving current page while data row changes

https://github.com/gravitational/teleport/assets/43280172/331bdce9-0e65-4aa5-bc43-8f41dc356ec4

github-actions[bot] commented 1 week ago

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

github-actions[bot] commented 1 week ago

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

kimlisa commented 1 day ago

friendly ping @rudream

public-teleport-github-review-bot[bot] commented 1 day ago

@kimlisa See the table below for backport results.

Branch Result
branch/v15 Failed
branch/v16 Failed