search

gravitational / teleport

The easiest, and most secure way to access and protect all of your infrastructure.
https://goteleport.com
GNU Affero General Public License v3.0
16.94k stars 1.7k forks source link

Fix linting errors in install scripts #43459

Closed fheinecke closed 4 days ago

fheinecke commented 4 days ago

This fixes the linting errors on the newly-migrated install scripts. These linter errors are blocking master branch merges. Not sure why they didn't trigger on the original PR.

github-actions[bot] commented 4 days ago

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

fheinecke commented 4 days ago

Confirmed locally that this fixes the issue via make lint-no-actions.

marcoandredinis commented 4 days ago

Not sure why they didn't trigger on the original PR.

It didn't because we only run the make lint-sh if there's a go change https://github.com/gravitational/teleport/blob/807167b647233d5cd3d58de200fc2cf9631a9b39/.github/workflows/lint.yaml#L137-L138 https://github.com/gravitational/teleport/blob/807167b647233d5cd3d58de200fc2cf9631a9b39/.github/workflows/lint.yaml#L47

So, if we add/change a shell script (without changing any *.go file) it will not run shellcheck.

fheinecke commented 3 days ago

Good catch. I'll put updating this workflow on my todo list.