search

gravitational / teleport

The easiest, and most secure way to access and protect all of your infrastructure.
https://goteleport.com
GNU Affero General Public License v3.0
17.39k stars 1.74k forks source link

Show a warning in tsh when connecting to a too old cluster #43461

Closed gzdunek closed 1 month ago

gzdunek commented 3 months ago

As per our compatibility promise, we don't support clients newer than servers. Unfortunately, we don't show any warning about it, so tsh may suddenly fail (like here https://gravitational.slack.com/archives/C01TYKHFVTQ/p1718877334960729). The only warning we have is about too old clients.

The new warning looks as below:

grzegorz@mbp build % ./tsh --proxy=teleport-ent-16.asteroid.earth login

WARNING
Detected potentially incompatible client and server versions.
Maximum client version supported by the server is 16.x.x but you are using 17.0.0-dev.
Please downgrade tsh to 16.x.x or use the --skip-version-check flag to bypass this check.
Future versions of tsh will fail when incompatible versions are detected.

changelog: tsh now shows a warning when connecting to a cluster on an older major version. More on client compatibility https://goteleport.com/docs/upgrading/overview/#component-compatibility

zmb3 commented 3 months ago

Does the skip version flag actually work with tsh?

gzdunek commented 3 months ago

Does the skip version flag actually work with tsh?

Yeah, passing --skip-version-check hides the warnings, but if the connection is terminated by the server, it obviously won't help.

public-teleport-github-review-bot[bot] commented 1 month ago

@gzdunek See the table below for backport results.

Branch Result
branch/v16 Create PR