gravitational / teleport

The easiest, and most secure way to access and protect all of your infrastructure.
https://goteleport.com
GNU Affero General Public License v3.0
17.58k stars 1.76k forks source link

Application browser is forcing the use of sentence case for no reason #4570

Closed webvictim closed 4 years ago

webvictim commented 4 years ago

What happened:

We seem to be inserting sentence case where there shouldn't be sentence case. With this config:

app_service:
  enabled: yes
  apps:
  - name: grafana-zeus
    uri: "http://zeus:<port>"
    public_addr: "grafana-zeus.teleport.w<redacted>"
    labels:
      name: grafana
      server: zeus
  - name: librenms
    uri: "http://zeus:<port>"
    public_addr: "librenms.teleport.w<redacted>"
    labels:
      name: lidarr
      server: zeus
  - name: unifi
    uri: "https://unifi:<port>"
    public_addr: "unifi.teleport.w<redacted>"
    labels:
      name: unifi
      server: zeus
    insecure_skip_verify: true
  - name: pihole
    uri: "http://artemis"
    public_addr: "pihole.teleport.w<redacted>"
    labels:
      name: pihole
      server: artemis
  - name: ombi
    uri: "http://hades:<port>"
    public_addr: "ombi.teleport.w<redacted>"
    labels:
      name: ombi
      server: hades
  - name: plexpy
    uri: "http://hades:<port>"
    public_addr: "plexpy.teleport.w<redacted>"
    labels:
      name: plexpy
      server: hades

This is how my applications are actually displayed:

2020-10-15-103232__808x584__maim

Also, the UI doesn't show any of the labels which have been set on the apps - not sure if that's deliberate or an oversight. We do show them for Teleport nodes, so I figure we should here as well.

What you expected to happen: My app names and public_addrs should display verbatim, not have arbitrary capital letters inserted.

How to reproduce it (as minimally and precisely as possible): Set up an app, load application browser.

Environment

webvictim commented 4 years ago

@alex-kovoy Any chance we can get this fixed before AAP goes out? It looks really weird to see capitals inserted that you didn't specify in your config file, especially in domains (which are always lowercase)

benarent commented 4 years ago

This was fix in the latest version of TAA. image