search

gravitational / teleport

The easiest, and most secure way to access and protect all of your infrastructure.
https://goteleport.com
GNU Affero General Public License v3.0
17.35k stars 1.74k forks source link

`TestParties` flakiness #45955

Open codingllama opened 3 weeks ago

codingllama commented 3 weeks ago

Failure

Link(s) to logs

Relevant snippet

=== Failed
=== FAIL: lib/srv TestParties (5.96s)
    sess_test.go:781: 
            Error Trace:    /__w/teleport/teleport/lib/srv/sess_test.go:781
            Error:          Condition never satisfied
            Test:           TestParties
{"caller":"srv/sess.go:218","component":"session:node","level":"debug","message":"Closing Session Registry.","timestamp":"2024-08-28T12:59:46Z"}
ravicious commented 3 weeks ago

https://github.com/gravitational/teleport/actions/runs/10613729976/job/29418151241#step:6:1624

codingllama commented 2 weeks ago

Hitting monthly dependency updates: https://github.com/gravitational/teleport/actions/runs/10670000493/job/29573084481?pr=46133

It seems easy to repro locally too (master on 069ebbcbaf).

Friendly ping @Joerger.

rosstimothy commented 2 weeks ago

https://github.com/gravitational/teleport/actions/runs/10689917103/job/29633132235


=== FAIL: lib/srv TestParties (6.07s)
    sess_test.go:781: 
            Error Trace:    /__w/teleport/teleport/lib/srv/sess_test.go:781
            Error:          Condition never satisfied
            Test:           TestParties
{"caller":"srv/sess.go:218","component":"session:node","level":"debug","message":"Closing Session Registry.","timestamp":"2024-09-03T20:19:22Z"}```
nklaassen commented 2 weeks ago

another hit https://github.com/gravitational/teleport/actions/runs/10708106180/job/29689641659

zmb3 commented 2 weeks ago

This may have been caused by #45544

275832ed27eac524b9a0d744bb475a7dc948f55d is the first bad commit
commit 275832ed27eac524b9a0d744bb475a7dc948f55d (HEAD)
Author: Brian Joerger <bjoerger@goteleport.com>
Date:   Sat Aug 17 10:28:51 2024 -0700

    Fix flaky test. (#45544)

 lib/srv/mock.go        | 7 ++++++-
 lib/srv/reexec_test.go | 2 +-
 2 files changed, 7 insertions(+), 2 deletions(-)
Joerger commented 8 hours ago

New hit in a recent flaky test daily report

https://github.com/gravitational/teleport.e/actions/runs/10594498376/job/29358266306