gravitational / teleport

The easiest, and most secure way to access and protect all of your infrastructure.
https://goteleport.com
GNU Affero General Public License v3.0
17.66k stars 1.77k forks source link

Resources cards/rows - Button widths are inconsistent w/designs and unnecessarily wide in card view #49295

Open roraback opened 2 days ago

roraback commented 2 days ago

Expected behavior:

In card view, buttons should have 2 sizes to take up as little horizontal space as necessary, in order to optimize for longer resource names. Connect, Launch, and Log-In buttons should be ~84px wide and "+ Request Access"/Request Role buttons should be ~124px wide. In table view, buttons should have uniform width so that they all align.

Also expected: Request Access buttons should be filled neutral buttons (no border, with level 0 spot background) to make it clearer that they are going to do something different from the Connect/Launch/Log In buttons.

Screenshot of design: Image

Current behavior:

Buttons currently always all have the width of the biggest button, "+ Request Access", except for segmented “Log In”/“…” buttons, which are overall ~24px wider than other buttons.

Screenshot from Teleport 17 in card mode. Note the unnecessarily wide buttons: Image

Screenshot from Teleport 17 in table mode with uniform buttons except the "Log In" segmented button: Image

Bug details: