gravitational / teleport

The easiest, and most secure way to access and protect all of your infrastructure.
https://goteleport.com
GNU Affero General Public License v3.0
17.66k stars 1.76k forks source link

fix connection tester error for Aurora databases #49336

Closed GavinFrazar closed 5 minutes ago

GavinFrazar commented 21 hours ago

Closes #47206

These changes were originally made to fix #47206. The fix for #47206 was preempted by https://github.com/gravitational/teleport/pull/48811 fixing a duplicate issue, but this PR still adds other database engines to the protocol conversion func, so I'm keeping that set of changes.

Other than that, this PR fixes a related (unreported) issue I came across where a user can try to test connection an Aurora Postgres without a "Database name" - that doesn't work because Aurora postgres requires a database name just like other Postgres protocol engines:

image

So this PR makes database name a required field in the connection tester for any "postgres" protocol db.

public-teleport-github-review-bot[bot] commented 2 minutes ago

@GavinFrazar See the table below for backport results.

Branch Result
branch/v15 Create PR
branch/v16 Create PR
branch/v17 Create PR