search

gravitational / teleport

The easiest, and most secure way to access and protect all of your infrastructure.
https://goteleport.com
GNU Affero General Public License v3.0
17.25k stars 1.73k forks source link

tsh FOSS client should warn when it talks to an enterprise server (or there should be no enterprise client) #6952

Closed highb closed 3 years ago

highb commented 3 years ago

What

What would you like Teleport to do differently?

When tsh FOSS connects to an enterprise server, it should emit some sort of recommendation that the user install the enterprise version instead.

How

How would you implement this?

Server-side API should emit a Enterprise vs FOSS flag, client-side should check that its flag matches. Or, even better, only ship one tsh binary that works regardless of Enterprise or FOSS.

Why

Why do you need this?

Users are my company are definitely going to install with brew install teleport and then we're going to have to deal with support tickets that tell them to re-install the enterprise version.

Workaround

If a workaround exists, please include it.

Re-install the enterprise client.

webvictim commented 3 years ago

@highb There's only one version of tsh for both OSS and Enterprise, the binaries are identical. If you run tsh version with either the OSS and Enterprise version installed, you'll get the same output.

Did you mean tctl instead?

highb commented 3 years ago

Ah, when I was chatting with support they indicated that we need to download the ent version of tsh. If that isn't the case then this can be closed. On May 26, 2021, 07:31 -0700, Gus Luxton @.***>, wrote:

@highb There's only one version of tsh for both OSS and Enterprise. Did you mean tctl instead? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

webvictim commented 3 years ago

Yep, there's only one version of tsh for both OSS and Enterprise so tsh installed via brew should work OK against any Teleport cluster.

FWIW, I would recommend that end-users install the Teleport-provided signed tsh pkg for Mac (https://get.gravitational.com/tsh-6.2.0.pkg) from our downloads page rather than using brew, as the package is smaller and it offers greater control of the version used.