search

gravitee-io / issues

Gravitee.io - API Platform - Issues
64 stars 26 forks source link

Make the helm-chart for apim 1.x more compatible with openshift #4062

Open oyviaase opened 4 years ago

oyviaase commented 4 years ago

The current helm charts for apim are not directly compatible with running in an openshift environment. There are a couple of small changes that can be implemented to the chart that helps with providing better compatibility with openshift.

Expected Behaviour

It should be possible to run just helm template apim ... --output-dir apim_install and then oc apply -Rf apim_install and get a working copy of gravtiee api-manager up and running

Current Behaviour

The current behaviour is that it is necessary to manually change parts of the configuration generated by the helm chart, or automaticly patch it with a script before deploying it to openshift

Possible Solution

We can provide PRs for both issues

Your Environment

brasseld commented 4 years ago

Hey @oyviaase

Do you think you can help on this by providing a PR ?

Regards,

oyviaase commented 4 years ago

Yes

We can provide PRs for both issues

oyviaase commented 4 years ago

I see that you already have fixed the issue regarding securityContext in this commit: https://github.com/gravitee-io/helm-charts/commit/8a3a242f574b98dcc6a1649e63d8a222c7861544 although I don't see it documented anywhere or used in the provided values file. Although it might be better to give it another name such as enableSecurityContext as it decides weather or not the securityContext is added to the generated template.

Here's the PR for adding support for openshift routes https://github.com/gravitee-io/helm-charts/pull/62

oyviaase commented 4 years ago

@brasseld is it possible to get any respons on the PR?

brasseld commented 4 years ago

@oyviaase I've put some comments. Please have a look. cheers.

oyviaase commented 4 years ago

@brasseld can you have another look at the PR? I've changed what you've asked us to change in it.