gravitee-io / issues

Gravitee.io - API Platform - Issues
64 stars 26 forks source link

[management] [multi-languages] storage at domain level #8071

Closed tcompiegne closed 2 years ago

tcompiegne commented 2 years ago

:rainbow: Feature

Following https://github.com/gravitee-io/issues/issues/8067 :

As a 'security domain owner'

I want to 'to create / update / delete my translation dictionaries'

So that 'I can propose new translations for my form and email templates'

:sunrise_over_mountains: Additional information

:link: Dependencies

https://github.com/gravitee-io/issues/issues/8067

:camera: Mockups

Capture d’écran 2022-07-14 à 21 54 56

image

:books: Documentation required

Provide link to the issue for documentation update

:superhero: Acceptance criteria

:warning: Potential impacts

Which other features may be impacted by this fix. This could be populated after fix

What are the impacted versions?

:rocket:

omatthewsgravitee commented 2 years ago

Hey team! Please add your planning poker estimate with ZenHub @ashraf706 @audrey-tlm @farmborough @leleueri @patelami @remisultan

patelami commented 2 years ago

@farmborough

there are different chevron symbol used to sort the language, display name, key and value alphabetically. However, I can only sort Key. sorting for Display, Language and Value is not working.

Also, i can not see the chevron sign in mockups, does is it make more sense to remove the sign completely?

Screenshot 2022-08-10 at 15 06 35
patelami commented 2 years ago

Please can we add data-testid to following elements:

  1. Language title: data-testid = textLanguageTitle
  2. Translations title: data-testid = textTranslationTitle
  3. Add a new language button: data-testid = textAddLanguageButton
  4. Delete button: data-testid = textDeleteButton
  5. Language code text box: data-testid =textLanguageCodeInput
  6. Display name text box: data-testid = textDisplayNameInput
  7. Add button: data-testid = textAddButton
  8. Cancel button: data-testid = textCancelButton
  9. language dropdown: data-testid = textLanguageDropdown
  10. Add new translation button: data-testid = textAddNewTranslationButton
  11. Save changes button = data-testid = textSaveChangesButton
  12. Key textbox: data-testid = textKeyInput
  13. Value: data-testid = textValueInput
  14. Add new key button: data-testid = textAddButton
  15. Cancel: data-testid = textCancelButton

I believe add and cancel button (7, 8, 14, 15 ) are same buttons.

farmborough commented 2 years ago

@patelami The chevrons are provided by the ng-datatable Angular tag (by default, it seems) and are present wherever data tables are used in AM. They also don't seem to be wired up in the other tables I checked (e.g. domain settings -> forms). I'll try and get them to work for all columns or see if it is possible to hide them.

patelami commented 2 years ago

closing this ticket as discussed with @farmborough, the above comments and data-testid will be added in different PR.