search

gravitl / netmaker-helm

34 stars 36 forks source link

Removing hardcoded endpoints from statefulset envvars #2

Closed wesparish closed 1 year ago

wesparish commented 2 years ago

Template the ingress values into the statefulset instead of hardcoding "api.fqdn" and "grpc.fqdn".

This allows users to change their exposed URLs, e.g. netmaker-api.example.com

afeiszli commented 2 years ago

apologies but this now has merge conflicts with new version, if you're willing to re-submit we would gladly merge this.

afeiszli commented 1 year ago

closing for now, you are welcome to re-open with changes.