gravitl / netmaker-helm

34 stars 36 forks source link

Support different classNames for assigning annotations to Ingresses (or drop the magic) #25

Open gw0 opened 1 year ago

gw0 commented 1 year ago

Currently, the className setting for Ingress contains magic to add annotations if it equals nginx, public, and traefic. The design is misleading, because one can install e.g. multiple nginx-ingress controllers each one under a different name. One would expect that annotations under .Values.ingress.annotations.nginx will be used for all of them.

Also noticed, that the MQ Ingress is missing base annotations.