search

gravitl / netmaker-helm

34 stars 36 forks source link

fix: Fixing various bugs with existingClaim and endpoint URLs #34

Closed wesparish closed 7 months ago

wesparish commented 1 year ago

Changes:

  1. (backwards compatible) Make the ingress className configurable, used to have to be "nginx" or "traefik". Now will index values.yaml path ingress.annotations. to pick up the map of annotations.
    • Note that "nginx" and "traefik" were already existing keys and happened to also be the hardcoded className
  2. (backwards compatible) Fixed hardcoded endpoint URLs to use the same values.yaml that already existed and was used to create the endpoint ingresses
  3. (backwards compatible) Fixed a logic error for values.mq.existingClaim (incorrect not check)
  4. (backwards compatible) Adding .Values.persistence.existingClaim for the netmaker statefulset. The default is "", which will use the pre-existing dynamic volume
  5. (backwards compatible) Adding default to values.yaml for mq.existingClaim: ""
wesparish commented 7 months ago

This PR has gotten stale with no review, closing unless someone else is interested