search

gravitl / netmaker-ui-2

Other
8 stars 13 forks source link

[Bug]: UI form for DNS entries only allow TLDs with up to 6 characters #402

Closed brunobriante closed 10 months ago

brunobriante commented 10 months ago

Currently the modal for DNS entries has a regex allowing only 2 to 6 characters in the TLD of an entry (regexline). This is not a validation that is made on the API itself, only on the frontend.

Based on the tld list maintained by IANA (which i got from ICANN) a TLD currently can have up to 24 characters and has P99 of ~15.48.

download

Currently i can't manage some of my domains (which are using the .service TLD) via the UI because of that. Can this regex be altered to a value that allow those longer TLDs or even up to 63 characters as per RFC-1123?

Aceix commented 10 months ago

thanks for raising this issue @brunobriante. we'll definitely consider this

Aceix commented 10 months ago

actually, this should be resolved in the next release. we already made the validation a bit looser since other users encoutered this issue ref: https://github.com/gravitl/netmaker-ui-2/blob/develop/src/components/modals/add-dns-modal/AddDnsModal.tsx