search

gravitl / netmaker-ui-2

Other
8 stars 13 forks source link

Img request to freepik is leaking referer #52

Closed FallingSnow closed 1 year ago

FallingSnow commented 1 year ago

Not a big deal but in my opinion a security focused application should not be making requests to uncontrolled 3rd parties. This images sources should be served from the dashboard's included assets.

https://github.com/gravitl/netmaker-ui-2/blob/5765dc8b2368b9ec616d2428ad474e2528a2bd38/src/layouts/MainLayout.tsx#L229-L234

By leaking I mean it sends the referrer. Screenshot from 2023-05-26 13-39-41

Aceix commented 1 year ago

fixed with https://github.com/gravitl/netmaker-ui-2/pull/53

Aceix commented 1 year ago

Thanks again @FallingSnow