gravitl / netmaker

Netmaker makes networks with WireGuard. Netmaker automates fast, secure, and distributed virtual networks.
https://netmaker.io
Other
9.4k stars 547 forks source link

Bad GPG configuration for RPM repository #1156

Closed chamburr closed 2 years ago

chamburr commented 2 years ago

I noticed the RPM repository configuration provided does not properly implement GPG signature checking.

The current configuration is:

[netclient-repo]
name=netclient 
baseurl=https://rpm.netmaker.org/packages
enabled=1
pgpcheck=1
pgpkey=https://rpm.netmaker.org/gpg.key

However, the correct keys to configure GPG signature checking are gpgcheck and gpgkey. I am afraid that GPG signature is not actually being checked due to the erroneous keys, which are unfortunately not aliases.

mattkasun commented 2 years ago

repo and build scripts updated.

chamburr commented 2 years ago

Thank you. I think you made a typo, it's not gpgkpey.

mattkasun commented 2 years ago

Thank you. I think you made a typo, it's not gpgkpey.

Good catch. Thankyou.. Fixed