gravitl / netmaker

Netmaker makes networks with WireGuard. Netmaker automates fast, secure, and distributed virtual networks.
https://netmaker.io
Other
9.52k stars 552 forks source link

[Bug]: Add possibility to set domain name instead of public ip #1290

Closed crustulumtheoneandonly closed 2 years ago

crustulumtheoneandonly commented 2 years ago

Contact Details

friedemannblume@gmail.com

What happened?

Could you add the option to edit the domain name of a node?

In an age of changing (Public)IPs it would add more redundancy from the netmaker-api / broker server if the wireguard vpn mesh uses domain names.

Version

v0.14.4

What OS are you using?

No response

Relevant log output

.

Contributing guidelines

mattkasun commented 2 years ago

where exactly do you want to set the node's domain name? there is no ui element for domain name of node

crustulumtheoneandonly commented 2 years ago

Maybe the field „Endpoint“?

Mit freundlichen Grüßen Friedemann Blume

Am Fr., 08.Juli.2022 um 16:55, Matthew R Kasun @.***> schrieb:

where exactly do you want to set the node's domain name? there is no ui element for domain name of node

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

mattkasun commented 2 years ago

To what end? This field is automatically updated by netclient whenever the public IP of a node changes. The netmaker sever then distributes the update to all peers.

crustulumtheoneandonly commented 2 years ago

I only know from simple Wireguard setups that it’s better to use a automatic updated dns record. (I’m talking about servers with dynamic IPs) In case of netmaker, this “update functionality” is covered by the netmaker-api.

The problem for high availability is, that if you don’t have netmaker server running in a seperate HA Cluster and netmaker server goes offline, the endpoint ip update is not longer possible. So it would make a lot of sense to add the possibility for a “static endpoint dns-record / domain” to keep the network alive in case the netmaker server goes offline and a node_public-ip changes.

You know what I mean?

Mit freundlichen Grüßen Friedemann Blume

Am Fr., 08.Juli.2022 um 19:12, Matthew R Kasun @.***> schrieb:

To what end? This field is automatically updated by netclient whenever the public IP of a node changes. The netmaker sever then distributes the update to all peers.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

mattkasun commented 2 years ago

Wireguard only resolves a DNS name when it first brings up the interface; after that it only uses IP addresses. Wireguard updates the endpoint of peer whenever it receives a message (including persistent keepalive signals) from a peer.

crustulumtheoneandonly commented 2 years ago

Oh ok I Unterstand

Sorry I didn’t know the exact behaviour of peer updates in Wireguard.

So I guess it’s not possible to add this feature as a fallback setting for redundancy.

Sorry for bothering and thanks for your time.

You are making great work with netmaker, I really appreciate it👍👍

Mit freundlichen Grüßen Friedemann Blume

Am Fr., 08.Juli.2022 um 22:01, Matthew R Kasun @.***> schrieb:

Wireguard only resolves a DNS name when it first brings up the interface; after that it only uses IP addresses. Wireguard updates the endpoint of peer whenever it receives a message (including persistent keepalive signals) from a peer.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

mattkasun commented 2 years ago

duplicate of #301