gravitl / netmaker

Netmaker makes networks with WireGuard. Netmaker automates fast, secure, and distributed virtual networks.
https://netmaker.io
Other
9.4k stars 547 forks source link

[Bug]: Windows service fails to start with 0.14.6 #1427

Closed pellz0r closed 2 years ago

pellz0r commented 2 years ago

Contact Details

No response

What happened?

After upgrading the Windows netclient to 0.14.6 the service fails to start (Error 1067: The process terminated unexpectedly). Nothing of value is seen in the Windows event viewer, but running 'netclient daemon' from CMD throws the following:

C:\Program Files (x86)\Netclient>netclient daemon [netclient.exe] 2022-07-27 22:47:51 netclient.exe is in proper location, C:\Program Files (x86)\Netclient\netclient.exe 2022/07/27 22:47:51 Gravitl Netclient on Windows started [netclient.exe] 2022-07-27 22:47:51 [daemon.go-46] Daemon(): netclient daemon started -- version: v0.14.6 [netclient.exe] 2022-07-27 22:47:51 [clientconfig.go-22] UpdateClientConfig(): checking for netclient updates... [netclient.exe] 2022-07-27 22:47:51 [clientconfig.go-48] UpdateClientConfig(): finished updates 2022/07/27 22:47:51 pid tracking not supported on windows

Guessing that the pid tracking is the culprit as netclient seem to terminate after that line.

Version

v0.14.6

What OS are you using?

Windows

Relevant log output

No response

Contributing guidelines

knd775 commented 2 years ago

I can confirm this. It happened on multiple windows devices here. Linux devices are fine.

afeiszli commented 2 years ago

hotfix is merged in https://github.com/gravitl/netmaker/pull/1429

We will have updated Windows binaries/installer later tonight or tomorrow morning

afeiszli commented 2 years ago

fixed via hotfix #1429