gravitl / netmaker

Netmaker makes networks with WireGuard. Netmaker automates fast, secure, and distributed virtual networks.
https://netmaker.io
Other
9.4k stars 547 forks source link

arm64 container images are only published on the test-workflow tag #592

Closed lnhrdt closed 2 years ago

lnhrdt commented 2 years ago

Based on comments in #480 I thought that arm64 images were being published but I ran into the same issues described in #457 when trying to run v0.9.3, v0.9.2, and v0.9.1. Then I looked at the actual images on docker hub and noticed that only the test-workflow tag has an arm64 version published. However that tag was published 2 months ago. I'd like to use the current version and upgrade when new versions are released.

Can you start publishing arm64 container images for new versions?

lnhrdt commented 2 years ago

Making things a little more complicated, I'm now also noticing that rqlite does not publish arm64 images (rqlite/rqlite-docker#12). Is that why you didn't start publishing arm64 images based on the work done in #480?

mattkasun commented 2 years ago

image

arm64 image is now on dockerhub

suggest you use sqlite rather than rqlite

lnhrdt commented 2 years ago

Amazing @mattkasun! Can you do the same for the netmaker-ui image as well?

mattkasun commented 2 years ago

docker hub now has arm64 image for netmaker-ui as well

lnhrdt commented 2 years ago

@mattkasun thank you I've got everything working now on arm64!

lnhrdt commented 2 years ago

Hey @mattkasun I wish I had seen this coming earlier, but could you also help get arm64 images published for the netclient image?

mattkasun commented 2 years ago

@lnhrdt I will put it in the backlog but it will be a low priority task as I (personal opinion) see no advantages to running netclient in a container. Just download the netclient binary for your architecture and join a network. Everything will be setup by joining a network. I am open to changing the priority if you have a compelling use case for running netclient in container. image

lnhrdt commented 2 years ago

Thanks @mattkasun! Your perspective is helpful – I'm still learning netmaker and understanding its architecture.

I'm interested in running a containerized version of the client because I'm managing the rest of my infrastructure on kubernetes. I find that it helps me automate patching and upgrades, as well as version control all of my configuration. And at this point it's just the most familiar/comfortable approach to me. I was trying to follow your kubernetes documentation here to setup my client nodes: https://docs.netmaker.org/server-installation.html#netclient-daemonset

Do you still think I should consider a native install? Is there something about the way netmaker works that I might be missing?

mattkasun commented 2 years ago

@lnhrdt my knowledge of kubernetes is limited. You may very well have a valid usecase.

lnhrdt commented 2 years ago

@afeiszli I see that you're the primary contributor on the netmaker k8s templates. Any thoughts here on if it's worthwhile to get the netclient container running on arm64 like the rest of netmaker's containers? Or am I barking up the wrong tree?

0xdcarns commented 2 years ago

We will/should add it to the workflow. That image was sort of an after thought that happened to be necessary/helpful for some k8s setups and we just never added it the workflow officially.

mattkasun commented 2 years ago

arm64 container available -- has been tested on an oracle arm vps and pi4

image

afeiszli commented 2 years ago

@mattkasun @lnhrdt are we good to close this?

lnhrdt commented 2 years ago

@afeiszli I haven't had a chance to test the netclient container yet but if you're eager to close the issue, no problem. If I run into any issues after digging in, I'll just reopen or open a new issue.

Thank you so much for your help @mattkasun and & @afeiszli!