search

gravitl / netmaker

Netmaker makes networks with WireGuard. Netmaker automates fast, secure, and distributed virtual networks.
https://netmaker.io
Other
9.51k stars 552 forks source link

2 feature requests #627

Closed n-able-consulting closed 2 years ago

n-able-consulting commented 2 years ago

I want to start with a callout: I think this is a marvelous project, using it for about a year now. Starting out there was a lot to improve upon, but so far I am impressed with how you bring it forward and the form and shape it is getting into. Thank you very much for all the good work!

I use netmaker as an overlay for my K8S HA Utility cluster, it spans multiple networks. Based on this experience I have two wishes or points for improvement: 1) I have a cluster with more than 10 servers, I would very much like a persistent global 'netmaker' setting where I could configure that my standard 'Rows per page' is 25/50/100/999.... 2) I automate the lot, so all I do and setup is idempotent and easily configurable, from head to tows. I like your client-install-commands setup, based on the access keys generated. It would help me a lot if I would be able to register my node clients with an argument for requesting setting a specific Ip-address (when not already in use). Now the addresses are being released in the order of clients, registering to the network. Automating the lot, is unpredictable, because of timing, having a way to set an IP during registering would make it predictable which server gets which IP. That will make it, for me, less hands-on and easier to program.

Greetings, Ruben Visser

afeiszli commented 2 years ago

Hi @n-able-consulting,

Thanks for reaching out! It's great to hear from an early adopter.

We actually have an open ticket for (1) in the netmaker-ui repo, I think that's the right place for that request: https://github.com/gravitl/netmaker-ui/issues/54

For (2), this is actually already supposed to be a feature. We have a flag ("-a" or "--address") and an env var (NETCLIENT_ADDRESS) that should set the private address while joining. However, I just tested and...it does not work. So I'm going to label this as a bug and use it to track that issue. The other one we can track in the UI repo.

n-able-consulting commented 2 years ago

Thank you for your response.

I call myself a failed IT, guy, because these days I am all over the place, functioning in a multitude of roles all over the change, operations, sales, management, and teach spectrum ;-). But as a (now maybe part-time) developer myself, I recognize the early part of projects, where restructuring or evolution cause breaking features. Your interface is so good, combined with the ease of the client-side server registration, that I had totally forgotten about the cli... Until after I added the request.

I am looking forward to your next release.

afeiszli commented 2 years ago

Rows per page and setting the address have both been tested and are functional as of 0.14.2.

afeiszli commented 2 years ago

to set address: netclient join -t (token) --address (address)