Closed itwillwork closed 1 month ago
@roberthovsepyan @Raubzeug what do you think?
As for me, separate build should be done 100%. But I'm not sure we should expose Parser and Lexer directly - it may spawn duplicate logic inside applications. As for me, common goals (autocomplete, syntax colorize) should be achieved inside library, and relevant api should be exposed. Parser and Lexer are low-level entities, they may change dramatically, and I think that user should not be aware of it. @NikitaShkaruba @roberthovsepyan
@NikitaShkaruba @roberthovsepyan what do you think?
I agree with @Raubzeug. I don't see why we now need the extra exports of parser, lexer. The rest is great
@NikitaShkaruba @roberthovsepyan @Raubzeug what are our next steps? Will you be able to do this task, or will we look for a volunteer?
@SeqviriouM we already implemented this Closing the issue now
Implemented in https://github.com/gravity-ui/websql-autocomplete/pull/196
Objective
The
dist/index.js
file from@gravity-ui/websql-autocomplete
is almost 5.2MBSolution Proposal
Assemble the build separately by language (clickhouse, postgresql, mysql и yql).
Definition of done
The required language can be imported modularly from the
@gravity-ui/websql-autocomplete
packageEx.