fix(withTableSettings): isSelected -> selected, isRequired -> required

[gravity-ui-bot]

Playwright Test Component is ready.

[gravity-ui-bot]

Preview is ready.

[GermanVor]

The problem is real

I rewrote TableColumnSetup but I did not think that it was public component. Interfaces TableColumnSetupItem also is public, but it is not connected with the TableSetting.

So, the best solution now to save backward compatibility in my opinion

• stop exporting new TableColumnSetup

• create separated TableColumnSetup component with code before I rewrote TableColumnSetup and export it

  3616e97c5a1618b6ab8e1e8a0f0ddded1dad4b87 645df5615cc52f419cd7cb57865af454ba1ad8be

  What to do with new created TableColumnSetup component I do not know - probably delete it in future, but now save it for backward compatibility.

  @teleginzhenya @Raubzeug

[teleginzhenya]

@amje @korvin89 @Raubzeug @ValeraS we've discussed it and decided to return backward compatibility of public api of TableColumnSetup component for now. Then we'll discuss next steps about this component, should it be exported as separate component or not.

[GermanVor]

@amje @korvin89 @Raubzeug @ValeraS

I begin rewrite new TableColumnSetup with the props of old one and I have new thoughts:

• If I rewrite a new component (TableColumnSetup with TreeSelect) for the old ones, then I risk breaking the new component and the old component (TableColumnSetup with List).

• The old component had props, which it is unclear how to apply to the new component (for example filter - there is no such property in TreeSelect)

• The behavior of the old component is slightly different from the new one - in the new component we allow the required columns to be moved, but we do not allow to hide them, while in old component case we moved required columns at the start of the list, without opportunity move them.

• The old component had the className option - it is not difficult to return it, but if the users used complex selectors, they are very likely will be broken cause TreeSelect probably is not comparable with List and Popup.

The best way to save backward compatibility in my opinion will be create TableColumnSetup with old code (code before i rewrote TableColumnSetup with TreeSelect) and export it instead of TableColumnSetup from withTableSettings.

In this case we 100% sure that new component will not be broken, users that use TableColumnSetup will get back component that they expected, old component 100% will not be broken.

And after that we will think what to do with TableColumnSetup.