Closed IsaevAlexandr closed 1 month ago
Preview is ready.
Playwright Test Component is ready.
I doubt the correctness of using of Box
for Text
and Flex
. Semantically, these components are needed for different tasks. For example, does the Text
component need props for its width/height and spacing?
I doubt the correctness of using of
Box
forText
. Semantically, these components are needed for different tasks. For example, does theText
component need props for its width/height and spacing?
these are reasonable remarks. The use of the Box
component in this example is necessary in order to work correctly with basic props such as qa
, styles
, className
and ref
and other. Like base logic fore thouse examples. Out of the box you get the ability to use Text component something like this:
<>
<Text spacing={{mr: 2}}>Some text 1</Text>
<Text>Some text 1</Text>
<>
Out of the box you get the ability to use Text component something like this:
<> <Text spacing={{mr: 2}}>Some text 1</Text> <Text>Some text 1</Text> <>
I think the question then might be why are we adding this behavior for Text
only?
Out of the box you get the ability to use Text component something like this:
<> <Text spacing={{mr: 2}}>Some text 1</Text> <Text>Some text 1</Text> <>
I think the question then might be why are we adding this behavior for
Text
only?
Text
is one more in a row. Flex
, Card
and, i hope, it will be more components soon what extends from Box
as
props forText
,Box
andFlex
components with backward compatibility;Text
component;related to https://github.com/gravity-ui/uikit/issues/1581