search

gravity-ui / uikit

https://gravity-ui.com
MIT License
516 stars 84 forks source link

test(Slider): CSF 3 & visual testing #1614

Open itwillwork opened 1 month ago

gravity-ui-bot commented 1 month ago

Preview is ready.

gravity-ui-bot commented 1 month ago

Playwright Test Component is ready.

Arucard89 commented 1 month ago

I suggest grouping single and range components in one page for each case. This will help reduce the number of menu items in the showcase section. I think it will be more convenient for watching.

amje commented 4 weeks ago

I suggest grouping single and range components in one page for each case. This will help reduce the number of menu items in the showcase section. I think it will be more convenient for watching.

Agreed, can we write the stories so we have both single and range slider, but with shared controls.value control will be the value for the single slider and rangeValue control will be the value for the ranged slider?

Arucard89 commented 4 weeks ago

I suggest grouping single and range components in one page for each case. This will help reduce the number of menu items in the showcase section. I think it will be more convenient for watching.

Agreed, can we write the stories so we have both single and range slider, but with shared controls.value control will be the value for the single slider and rangeValue control will be the value for the ranged slider?

@amje, Maybe we could omit the value property altogether? I don't think it is really necessary for the showcases(excluding the default showcase).

UPD: So my point is to have: -single page for slider(with value prop) -single page for range slider(with value prop) -single and range components in one page for each other special case(without value prop)

amje commented 4 weeks ago

I suggest grouping single and range components in one page for each case. This will help reduce the number of menu items in the showcase section. I think it will be more convenient for watching.

Agreed, can we write the stories so we have both single and range slider, but with shared controls.value control will be the value for the single slider and rangeValue control will be the value for the ranged slider?

@amje, Maybe we could omit the value property altogether? I don't think it is really necessary for the showcases(excluding the default showcase).

UPD: So my point is to have: -single page for slider(with value prop) -single page for range slider(with value prop) -single and range components in one page for each other special case(without value prop)

@Arucard89 Like this? Default (single default with value) Range (range default with value) Size (both single and range without value) Disabled (both single and range without value) // etc

Arucard89 commented 4 weeks ago

@Arucard89 Like this? Default (single default with value) Range (range default with value) Size (both single and range without value) Disabled (both single and range without value) // etc

@amje, yes. I believe that it would be helpful for users to play around with the components using the default settings and explore the special, predefined cases.