search

gravity-ui / uikit

https://gravity-ui.com
MIT License
516 stars 84 forks source link

fix(select): connect combobox to listbox #1665

Closed ValeraS closed 1 week ago

gravity-ui-bot commented 1 week ago

Preview is ready.

gravity-ui-bot commented 1 week ago

Visual Tests Report is ready.

IsaevAlexandr commented 1 week ago

Hi, what is the motivation of that changes? I'm asking because we have the same logic in TreeSelect component

ValeraS commented 1 week ago

The combobox element should set aria-controls to a value that refers to the element that serves as the popup. The popup is an element that has role listbox, tree, grid, or dialog. In case of this component it should be a listbox.