search

gravity-ui / uikit

https://gravity-ui.com
MIT License
516 stars 84 forks source link

feat(Slider)!: support form #1670

Open ValeraS opened 1 week ago

gravity-ui-bot commented 1 week ago

Preview is ready.

gravity-ui-bot commented 1 week ago

Visual Tests Report is ready.

Arucard89 commented 1 week ago

@ValeraS hi.

I see deep refactoring of basic component which adds breaking change and very specific case of usage .

May be you consider to make HOC (withForm) or new FormSlider wrapper component based on Slider component? in this case, you could add changes you need and move away from deep refactoring of the Slider and avoid breaking changes.

@korvin89 , @amje , what do you think about it?

korvin89 commented 1 week ago

@Arucard89

I see deep refactoring of basic component which adds breaking change

I think it is okay for the major version

May be you consider to make HOC (withForm) or new FormSlider wrapper component based on Slider component?

We are trying to add this functionality to all uikit controls into the core code

Arucard89 commented 1 week ago

@Arucard89

I see deep refactoring of basic component which adds breaking change

I think it is okay for the major version

May be you consider to make HOC (withForm) or new FormSlider wrapper component based on Slider component?

We are trying to add this functionality to all uikit controls into the core code

oh, I see. There was no description, so I didn't know that it is planned work