search

gravity-ui / uikit

https://gravity-ui.com
MIT License
623 stars 93 forks source link

Label with type `copy` not react to `interactive=false` #1890

Open saxumcordis opened 1 month ago

saxumcordis commented 1 month ago

Label has interactive prop, that controls hover state. But Label with type='copy' is always hovering, while interactive=false (https://github.com/gravity-ui/uikit/blame/main/src/components/Label/Label.tsx#L91)

(broken commit https://github.com/gravity-ui/uikit/commit/786e706e15e1de8661c182f45d97b0783869789d#diff-88ff8e2e9dbb3e1b0ed65052b25f8b38680c849327d50774610a16fed9066706R90)

ykamendrovskiy commented 1 month ago

Hey @saxumcordis. Thanks for the report. Our initial intention was to give a possibility to copy a value with a click on it (some labels could be long). But we'll revisit that solution. For now, we'll take some time to look at interactive property in combination with different types like copy and close. cc @korvin89