search

gravityblast / musix_match

API wrapper for musixmatch.com API's
Other
33 stars 7 forks source link

Custom exceptions should inherit from StandardError not Exception #1

Open masterkain opened 12 years ago

masterkain commented 12 years ago

Exception is too high level in the tree: http://whynotwiki.com/Ruby_/_Exception_handling#Exception_hierarchy

Currently when rescuing exceptions thrown by musix_match with rescue => ex will not trap anything.

gravityblast commented 12 years ago

Yes, I think the best way is to change all the custom exception and make them inherit from StandardError. what do you think?

gravityblast commented 12 years ago

you told me that in the title, I replied just after reading the body :) feel free to send me a pull request!