search

gravityblast / web-app-theme

A simple theme for web apps
Other
2.45k stars 387 forks source link

Support for Rails 3.1 asset pipeline #42

Closed jweslley closed 5 years ago

jweslley commented 12 years ago

Since Rails 3.1 is almost out, I guess web-app-theme can be improved when using the new Rails feature, the asset pipeline. In addition to explore this new feature, changing the application theme can be easy than ever, just editing a single line in application.css file*. Thus, the application.css could be so simple as the following:

/*
 *= require 'web-app-theme'
 *= require 'web-app-theme/default'
 *= require_tree . 
 */

The first line include the web-app-theme's basic/common styles previously located in base.css file. While the second one includes all theme-specific styles.

nathanvda commented 12 years ago

Nice work. My approach was more conservative :)

rgabo commented 12 years ago

any update on the rails 3.1-compat pull requests, @pilu? We're using this pull request. We ran into an issue with asset:precompile which is a known issue with Rails 3.1.0 official, also our configuration was generated with rc6 and some of the asset-related settings were misconfigured (cache, digest, etc). Otherwise, this pull request worked great. No wonder it is issue #42 :)

leehambley commented 12 years ago

Just spotted this, looks like awesome work, can't wait to see where it goes next!

dryaf commented 12 years ago

nice! i hope it s getting pulled soon

gravityblast commented 12 years ago

hi guys, I already merged something from other forks. Pull from my master branch, check if everything is ok, and then I'll merge in your changes. Thank you!

willthames commented 12 years ago

I've attempted to merge pilu/master back into jweslley/master. git@github.com:willthames/web-app-theme.git

Looking at the network graph it doesn't seem to reflect how the branches do come together, however - I may have made a git mistake somewhere (perhaps I should have merged the other way around).

I'm not clear how assets are generated now, since the web-app-theme/assets generator no longer exists.

Otherwise my fork reflects most of pilu/master's recent history and works with 3.2 as per slainer68's fix in #49.

gravityblast commented 12 years ago

hi guys, I can't automatically merge this request, maybe some conflicts. if you try to rebase or fix that I'll merge it asap, thank you!

RobertAudi commented 12 years ago

Please merge one of the asset pipeline compatible pull requests so that we can use web-app-theme with rails 3.2...

gravityblast commented 12 years ago

Hi, if you guys can manage this now I can give you write access to the repository. Let me know if you can, thank you!

sheam commented 12 years ago

Is there a way I can use this pull in my rails 3.2 project? What line do I need in my gem file?

rgabo commented 5 years ago

Is there a way you can close this PR? It has been showing up in my PR list since 2012 😉 Happy 2019, everyone!

elia commented 5 years ago

@rgabo does unsubscribing do the trick? Happy 2019! 😜

rgabo commented 5 years ago

@elia it doesn't 😢

it_doesnt

elia commented 5 years ago

@rgabo I'll close this, happy github inbox-zero! 😉

rgabo commented 5 years ago

Grazie mille, @elia! 😄