search

gravitylow / Updater

Easy automatic updates for Bukkit
MIT License
35 stars 41 forks source link

Updater downloads older versions when current plugin-version is not uploaded on bukkit yet #16

Closed Carlgo11 closed 10 years ago

Carlgo11 commented 10 years ago

When running a newer version (1.1 for example) when the newest version on bukkit is older (1.0 in this case) the Updater downloads the older version on bukkit.

Serverlog example: http://pastebin.com/8BxRJfaZ

gravitylow commented 10 years ago

https://github.com/gravitylow/Updater/commit/bdcbc343eec35b11f6222070280a5d792e56a6d5

I reverted the changed that fixed this on purpose. The reason for this is that there is no good way to check if a certain version is ahead of others due to the complexity of some of the versioning schemes. Moreover, there's no standard or guidelines that people use to version their plugins, so including code that disables updating sometimes causes some of these plugins to be stuck on a certain version without their knowledge.

It simply can't be done for all plugins. If you want to implement a function that will do the math and figure it out for your specific versioning scheme, feel free to do so. I may consider adding a blank function that you can override later to add this more easily in the future.

Carlgo11 commented 10 years ago

Okay thanks for the überfast reply ^_^

gravitylow commented 10 years ago

See: https://github.com/gravitylow/Updater/commit/69ef5ca3b67b23aad875d948d99a8ca1772a9ceb