gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.53k stars 817 forks source link

Add icon for amenity=school #120

Open al-- opened 11 years ago

al-- commented 11 years ago

Is the green school icon education_school p 16 missing? Why?

Brian also did icons for kindergarten or university...

/al

gravitystorm commented 11 years ago

Please explain what you mean more clearly. Was the icon in the old stylesheet? Is the wrong icon shown now? Are icons shown for any educational establishment?

The clearer you make the request, the easier it is to deal with.

compdude commented 10 years ago

@gravitystorm, in my three years as an OSM mapper, I don't think this icon has ever been rendered on nodes tagged as amenity=school. According to Taginfo, there are 323,732 nodes tagged with amenity=school, about 100,000 more than the number of ways having this tag. Currently all that shows up on the map is a name but no icon. It would be nice to have this icon.

matkoniecz commented 9 years ago

I think that this icon would not improve readability over context and area (for larger school) and name (for both large and small).

dieterdreist commented 9 years ago

2014-10-22 21:20 GMT+02:00 Mateusz Konieczny notifications@github.com:

I think that this icon would not improve readability over context and area (for larger school) and name (for both large and small).

+1. Not sure any icon is needed.

althio commented 9 years ago

We should not assume that every school has a name or is tagged with a name. from taginfo: amenity=school with name=* :: 526 000 (83%) amenity=school without name=* :: 106 000

An icon is useful for schools without name. An icon is needed IMO for school on nodes, and nice to have on areas. An icon takes less space than a name and could be rendered earlier or with less clash from other icons and labels. [also a valid comment for #660]

The label name on the other hand should be rendered very late. Absolute zoom levels are not enough since rendering icons and/or labels depends on the size (area) and on the density of features (clashes).

Lastly, when the school is mapped with details, the icon rendered is playground. Confusing for people looking for an public playground and confusing for people looking for the school (school can be used as any landmark and locally well-known place for orientation). The school icon or label should somehow have more weight than the playground-in-a-school icon.

daganzdaanda commented 9 years ago

+1 for adding an icon for schools. In some areas of Africa, I've seen lots of schools that are just nodes (maybe imported). These don't always have a name. I'd rate schools important enough that the icon should be visible at z>=14 like hospitals.

dispiste commented 8 years ago

+1 for adding an icon for schools. Copy-pasting some reasons from talk mailing list:

"At least in Spain, they are very important buildings from several points of view:

Regarding the icon to use, I've found in Google a number of topics that work for successfully representing a school: blackboard, child(en), teacher, backpack or school bag, pencil, notebook, compass, protractor, ruler, abacus...

I specially like the following combinations:

kocio-pl commented 8 years ago

My first set of drafts: 1) school-14-1 2) school-14-2 3) school-14-3 4) school-14-6 5) school-14-7 6) school-14-8

and a real preview with 4) (compared to museum and police station): school-icon-alone-17

It lacks the name label, because it's just temporary code flashback - we have to fix this regression first and only then it will make sense to work more with the code.

rmikke commented 8 years ago

I'd say icon number 2 is the most readable.

matkoniecz commented 8 years ago

1, 2 looks like a subway train on tracks for me.

3, 4 are preferable (but I am still not convinced that adding icon here is a good idea)

kocio-pl commented 8 years ago

I also think 1, 2 may be too similar to train, that's why I think a letter is important.

Regarding the icon itself - I think school is very similar to hospital, it's just not health-related, so the color should be different, and also similar to other amenities like museum or police station. I think this comment summarizes why it's a good thing (+ language independence of course - try to find school in China for example).

polarbearing commented 8 years ago

+1 for shape 3 and 4. As for the colour, we might consider this together with other "Societal amenities" as discussed in #1624.

Should amenity=kindergarten also get an icon once school gets one?

kocio-pl commented 8 years ago

We have also university and college amenities and we can go in many directions. All those POIs are similar, so: 1) we can give them all the same icon, because now they are rendered the same (blackboard=education) 2) we can give blackboard for lower levels of education (kindergarten + school) and create hat icon for higher levels (university + college) 3) we could also try to make a special icon for kindergarten (different than playground)

Of course it's not sure that those icons would be accepted, but it's good to know if we want them - maybe one for all would be enough and it's not worth even trying to draft more?

BTW - the amount of POIs with names is also similar:

so 10-20% of educational amenities can be seen only if they are tagged on buildings or areas.

HolgerJeromin commented 8 years ago

many pois without a name i found were duplicate in this location. For example a lone area with school and a building or node in it with the details. or an area with alle details and the building itself has a amenity=school tag.

This is valid only for good mapped places.

EDIT: yes, this is a tagging error. I wanted to say, that the numbers of unnamed education things are perhaps not so bad.

polarbearing commented 8 years ago

@kocio-pl - my preference would be separate icons. For Univ/college, a college hat is often used, for schools the blackboard, and for kindergarten I was thinking about reusing the shop=toy icon just in different colour (however this is currently a rocking horse, that might not be optimal for kindergarten).

@HolgerJeromin - duplicate tagging is a tagging error (that becomes more visible with the icon). Once the campus is mapped as amenity, it should be removed from the building, only building=school should remain. Exception might be a campus shared by separate schools that cannot be divided horizontally.

kocio-pl commented 8 years ago

So we can start with blackboard for schools and once we know if the other icons are good enough, we can add them later (or just expand the scope of the blackboard icon in case these attempts fail).

What's your ideas for kindergarten to test? Remember we have only 14x14 px in one color, so the simpler and more characteristic shape, the better.

HolgerJeromin commented 8 years ago

perhaps the new community_centre icon with two people can be modified to have one big and one small person.

kocio-pl commented 8 years ago

You talk about the idea for kindergarten icon - or maybe more than that (lower level education or maybe education in general)?

HolgerJeromin commented 8 years ago

Kindergarten. School could be (in Germany) to the age of 19 years. There students are taler than the teachers (ok, would result in the same icon :-) Joking aside. The metaphor: kindergarten is more caring (big/small person) and school is more teaching (with an "A") works IMO.

kocio-pl commented 8 years ago

University draft: 1) university-14-12 Kindergarten draft: 1) kindergarten-14-3 2) kindergarten-14-8

HolgerJeromin commented 8 years ago

i like both 1). Kindergarden is really good IMO. 2) is for me not clearly human, but could be a gas cylinder :-)

kocio-pl commented 8 years ago

I like it less, because visual details are not so clear, but it's still usable. 2) is more like a playground icon.

dispiste commented 8 years ago

I like the university icon and also the 1) kindergarten icon.

Regarding the school icon, it is not evident for me that it represents a blackboard (nor a school). What does the A stand for?

I attach some icons that may provide some inspiration for school. I have no idea on icon design, so they probably have to be re-worked a bit to look more professional. They are based on your kindergarten icon:

1) desk 2) desk2 3) desk3 4) desk4 5) blackboard1 6) blackboard0

kocio-pl commented 8 years ago

Thanks a lot! We need more contributors to make healthy community, no matter what kind of input. I like 5) the most, because it's not too light. Do you have SVG for that or is it only a raster draft?

dispiste commented 8 years ago

It is only a pixel-drawn raster draft.

dispiste commented 8 years ago

I've now created some SVG versions of 5), but I'm not sure they are clear enough when rendered to 14x14:

5.1) osm-school0 (osm-school0.svg) 5.2) osm-school2 (osm-school1.svg) 5.3) osm-school3 (osm-school2.svg) 5.4) osm-school (osm-school.svg)

Is three any vector-drawing magician in the room who can improve the result?

polarbearing commented 8 years ago

Thanks @dispiste for the contribution. Though the "blackboard against the wall" is the more typical real-world setup, the "blackboard on the easel" appears to me more recognisable as a school in the small icon format.

kocio-pl commented 8 years ago

Could you share the osm-school.svg file (5.4)?

It's most probably problem of pixel aligning - if we make the proper scalable icon, this is not always possible, but we can try making bigger gap for example.

BTW: I like solid icons more and here is my next attempt (3 + 6): 7) school-14-9

dispiste commented 8 years ago

Thanks @kocio-pl for your efforts. SVG 5.4 is available here: https://github.com/dispiste/dispiste.github.io/blob/master/osm/symbols/osm-school.svg

I've uploaded all of them to: https://github.com/dispiste/dispiste.github.io/blob/master/osm/symbols/

dispiste commented 8 years ago

Two more variation added: 5.5) osm-school5 5.6) osm-school6

Available on: https://github.com/dispiste/dispiste.github.io/blob/master/osm/symbols/osm-school5.svg https://github.com/dispiste/dispiste.github.io/blob/master/osm/symbols/osm-school6.svg

kocio-pl commented 8 years ago

Are we still interested in icons for educational institutions? If yes, I could provide the code (once we decide which icon would be the best for school), otherwise it should be closed.

daganzdaanda commented 8 years ago

I still would like to see an icon for schools. Universities, Kindergartens / Childcare facilities would make sense, too.

kocio-pl commented 8 years ago

IIRC university and kindergarten icons are ready and I guess the best school icons left to choose from are: 7) school-14-9 5.6)

polarbearing commented 8 years ago

Still prefer 7) typus, see comment 25 Sep 2015.

For Kindergarten, could we have the icon more oblique, so that the children appear running? Similar dynamic was brought into the related German traffic sign a while ago.

dispiste commented 8 years ago

Although I feel we have not found the perfect icon for schools yet, I think the proposed icons are better than nothing, so please go for it. It will be really useful.

On 21 February 2016 at 23:26, polarbearing notifications@github.com wrote:

Still prefer 7) typus, see comment 25 Sep 2015.

For Kindergarten, could we have the icon more oblique, so that the children appear running? Similar dynamic was brought into the related German traffic sign https://upload.wikimedia.org/wikipedia/commons/e/eb/Zeichen_136-10.svg a while ago.

— Reply to this email directly or view it on GitHub https://github.com/gravitystorm/openstreetmap-carto/issues/120#issuecomment-186933691 .


César Martínez Izquierdo GIS developer


SCOLAB: http://www.scolab.es


kocio-pl commented 8 years ago

@polarbearing It was meant to be adult with child, so I think static version is better to not be confused with school kids.

polarbearing commented 8 years ago

Yes I know the intended meaning. My concern is to differentiate clearly against the two people in the community_centre, thus having them running in the kindergarten icon would help. There is no visual overlap with the blackboard proposed here for school. Further, amenity=kindergarten is increasingly used for afternoon care of primary school kids (de: Hort). Thus, two running kids of slightly different size would be fine for me.

daganzdaanda commented 8 years ago

University: yep, thats good!

Kindergarten: Running children might be a bit more intuitive than a static grown-up and child. What do people outside of Germany think? Another option might be some toy blocks, but I believe that would be harder to read at the small size.

Schools: I like both icons 7 and 5.6, don't have a real preference.

jragusa commented 6 years ago

I can test rendering if you're still interested to show icons for this amenities. I just need links to svg icons

jragusa commented 6 years ago

@kocio-pl ping ?

kocio-pl commented 6 years ago

The PR was created but closed (#2361) because I don't know how to deal with label scaling in such cases.

jragusa commented 6 years ago

Oups, sorry for the disturbance

kocio-pl commented 6 years ago

No problem. :smile:

jeisenbe commented 5 years ago

See #3856 for examples of aerodrome labels and icons which are adjusted to different sizes at different zoom levels.

sun-geo commented 3 years ago

I found icons for schools using osm.org (on left panel), the iD editor and JOSM, see below .

school icon

I was wondering if the osm-carto map might also show it.

Then i found this long standing discussion and hope it will be implemented one day. I don't understand the mentioned scaling issue. Could it maybe just work the same way which is implemented for the other similar yellow area object-icons (amenity=community_centre / amenity=social_facility / amenity=arts_centre)?

image

Circeus commented 1 year ago

I don't understand the mentioned scaling issue.

Whether or not the names of some features such as parks and Cemetary are visible is beholden only to the amount of available space to draw the name rather than the zoom level. A feature with label scaling that is large enough can have its name shown at any zoom level as long as it is traced and there's room to fit the name. This is especially noticeable with national parks or military bases, which have names as far out as zoom 8 (they are no longer traced at zoom 7).

By contrast, anything with an associated icon is strictly limited by zoom levels. Calverton National Cemetery has a name visible as early as zoom 13. By contrast, no hospital anywhere in the world has a name visible before zoom 16. Their icons don't show up at zoom 14. Scaled labels are also much less restricted by collision limits with nearby features.

So basically a choice has to be made between name scaling and having an icon. I think most people prefer scaled labels over icon issues.