gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.53k stars 822 forks source link

Add special rendering for shop=musical_instrument #1420

Closed kocio-pl closed 9 years ago

kocio-pl commented 9 years ago

We should start rendering shop=musical_instrument, probably with this icon from osmfr-cartocss fork:

https://github.com/cquest/osmfr-cartocss/blob/master/symbols/musical_instrument.svg

[It was proposed in meta-issue #1402]

nebulon42 commented 9 years ago

This icon is already in use for amenity=nightclub.

kocio-pl commented 9 years ago

I think it could be more specific - like guitar or piano. But wasn't it disco ball that we were trying to apply here or was it some other tag?

kocio-pl commented 9 years ago

My proposition: 1) musical_instrument-14-4

lest69 commented 9 years ago

I know what it's supposed to be, but I'm concerned it could be confused with other things (shoe, ice skate, cleats, etc.). Can you maybe try a guitar?

kocio-pl commented 9 years ago

That was what I started with, but the result was rather poor, so I'm still trying: 2) musical_instrument-14-1 3) musical_instrument-14-3

kocio-pl commented 9 years ago

Another take: 4) musical_instrument-14-5 5) musical_instrument-14-6

kocio-pl commented 9 years ago

Hm, maybe saxophone would do...

@nebulon42 Do you have any ideas or actual drafts for this shop type?

matkoniecz commented 9 years ago

3) is the best from proposed ones

nebulon42 commented 9 years ago

I have no special ideas. I think any musical instrument could work. 2 or 3 maybe, with some tweaking.

daganzdaanda commented 9 years ago

A trumpet is a good symbol, I think. Number 3) has no piston valves in the middle, maybe they could be added to reduce the "hole".

kocio-pl commented 9 years ago

So the popular opinion is clear - I will try to work with the trumpet.

kocio-pl commented 9 years ago

All about details, which are visible mostly at higher resolutions, and slightly better with current icon size: 7) musical_instrument-14-24

matkoniecz commented 9 years ago

I think that 3) is still the best (7 started to look like scheme of electronics, with diode on the left and resistor on the bottom).

kocio-pl commented 9 years ago

Maybe I have tried too hard to make everything visible (piston valves left untouched): 8) musical_instrument-14-25 9) musical_instrument-14-26

matkoniecz commented 9 years ago

to keep also 3) easy to compare:

3) musical_instrument-14-3 8) musical_instrument-14-25 9) musical_instrument-14-26

matkoniecz commented 9 years ago

3) and 9) are the best.

kocio-pl commented 9 years ago

What about piston valves?