gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.53k stars 819 forks source link

Add rendering for emergency=defibrillator #1603

Open kocio-pl opened 9 years ago

kocio-pl commented 9 years ago

This is similar to https://github.com/gravitystorm/openstreetmap-carto/issues/318 and https://github.com/gravitystorm/openstreetmap-carto/issues/1160 and it also depends on https://github.com/gravitystorm/openstreetmap-carto/issues/1504 (database re-import).

This is one of the most popular emergency items (8 621 uses on Taginfo).

I think the icon should be like this: 1) defibrillator-14-2

in a color and text style of health amenities, but rendered from z>=18, or even 19.

I'm aware that there were already some discussions about it, but we should gather the opinions about it somewhere, especially when there's a draft for the icon.

mboeringa commented 9 years ago

Icon seems sound, as it follows the most used standard for this. However, to improve recognizability, maybe also stick with the green color often used?

kocio-pl commented 9 years ago

Nice idea! I was not aware there is a color associated with it, but it would help us a lot probably. Any (hex) shade that we should try?

lest69 commented 9 years ago

It seems like green isn't always used. Colour usage seems to be split between green and red.

Since #1355 may use green for other objects and I don't think we're using green for any other icons right now (are we?), maybe it would be best to just use the health amenity red/purple?

matthijsmelissen commented 9 years ago

I'm not quite sure about rendering this icon. What would be the use case in which it would be useful for someone to have this icon on the map?

HolgerJeromin commented 9 years ago

The use case is that you get aware of them in your local area so that you remember them in case of an emergency.

kocio-pl commented 7 years ago

Now I think it doesn't fit the general style, so closing this ticket.

rjw62 commented 7 years ago

I think the usecase given by HolgerJeromin above is very important. These potentially life-saving devices are only useful if people know where they are. Showing them on the map would help raise awareness of their locations. I'd therefore like to see this ticket re-opened.

kocio-pl commented 7 years ago

Two important questions:

  1. Do they belong to a general map?
  2. If yes - how should they be rendered?
rjw62 commented 7 years ago

For Q2: Presumably we should base any icon on the ILCOR standard described at http://www.ilcor.org/news/news-archive/ilcor-presents-a-universal-aed-sign but possibly simplified a bit to work better at small sizes. Whether it should be green (to match the standard) or pink (to match our other emergency/health icons) is an open question.

kocio-pl commented 7 years ago

I mean something more concrete than general look - we need a vector icon which fits 14px matrix.

I still think that being important doesn't mean being general - it's a specialized device and should be visible on special style.

matthijsmelissen commented 7 years ago

Nowadays about every office block has a defibrilator in the Netherlands. I'm afraid rendering them would flood the map.

pnorman commented 7 years ago

Nowadays about every office block has a defibrilator in the Netherlands. I'm afraid rendering them would flood the map.

Yes - even though I think they're important and don't belong on a general map, if I did think they should be rendered, there's the practical problem that they either tend to overlap with another POI, or be in an area where rendering them would flood the map.

jojo4u commented 7 years ago

Waste baskets are rendered and much more abundant. Only public defibrillators should be rendered. The ones in office buildings should get access=private.

HolgerJeromin commented 7 years ago

Many waste baskets are next to nothing or a bench in a park and is not overlapping many shop POIs. So IMO both are not comparable. I am not sure if they are too much...

SomeoneElseOSM commented 6 years ago

Personally I don't buy the "not enough room" argument. Even though OSM's "standard" tiles only support up to z19, at z19 there's plenty of room for a small icon:

https://map.atownsend.org.uk/maps/map/map.html#zoom=19&lat=53.163729&lon=-1.415489

dktue commented 6 years ago

Can we reopen this issue, please?

kocio-pl commented 6 years ago

Sure we can, but the question is on which merits?

dktue commented 6 years ago

I agree with @SomeoneElseOSM that there's plenty of room at z19 and those defibrillators that are accessible by the public should be visible to raise awareness -- so that you know where they are in case of emergency.

In my city we have a public list of publicly available defibrillators that has been mapped into OSM. I think there's real advantage to show them without cluttering the map.

kocio-pl commented 6 years ago

I think there's real advantage to show them without cluttering the map.

I can't agree with it, see here:

http://overpass-turbo.eu/s/yCJ

screenshot-2018-5-8 overpass turbo

They are competing with shops, offices, pubs and other objects even now, because they carry an address tag (see #962).

dktue commented 6 years ago

But they can all be rendered whithout any label-collision at this level -- I don't see any problem.

kocio-pl commented 6 years ago

I don't say about label collisions, only about clutter. I mean they are small indoor facility which are visible the same as other, bigger amenities. Even bus stops and bicycle parkings are less visible, because they are not located on the buildings.

I have moved toilets to z19+ lately (#3055) exactly because they can be indoor facility (think of a toilet in the cafe), but they are bigger and more useful in a daily life. Defibrillator belongs to an emergency kind of map.

dktue commented 5 years ago

How about only rendering those defibrillators that are publicly accessible?

Adamant36 commented 5 years ago

They could be added to the "health" category ;)

dktue commented 5 years ago

@Adamant36 or the emergency category ;)

SomeoneElseOSM commented 5 years ago

How about only rendering those defibrillators that are publicly accessible?

A surprising (to me anyway) of these do have an access tag:

https://taginfo.openstreetmap.org/tags/emergency=defibrillator#combinations

jragusa commented 5 years ago

@Adamant36 I agree to display emergency tag with the same colour than heath tag scheme

@dktue that's would be related to #1012

@SomeoneElseOSM I think they distinguish facility available in public space to those located in office and storage site of companies for example.

rbovard commented 5 years ago

So just to be sure, there will be no way to add emergency=defibrillator in the rendering at z=19?

If that's the case, I find it really unfortunate because these POIs could be very important in some situations.

dktue commented 5 years ago

@rbovard : You have my backup: I really want them to be rendered. Because rendering does not only show things for consumers of the map but also encourages mappers to put this type of feature into openstreetmap.

rbovard commented 5 years ago

@dktue: Yes, you're absolutely right.

@kocio-pl: Could you please reconsider reopening this issue? I also checked taginfo and there is now 18'600+ entries in database, which is the 4th most used value in emergency key.

kocio-pl commented 5 years ago

The numbers are not the problem (they're quite high), but I think rendering it would clutter even z19. If we have z20, that might be worth reconsidering, however we're mostly trying to follow osm.org and there's only z19 for now.

rbovard commented 5 years ago

I understand your fears but cannot agree with them.

You've mentionned the toilets you've moved to z19+, why not doing the same for defibrillators? Saving a life is at least as important as going to the toilets for me.

kocio-pl commented 5 years ago

For me guiding principle for general map like this is size. Bigger life saving objects (like hospitals) are well visible and I think this is OK.

SomeoneElseOSM commented 5 years ago

@rbovard

I find it really unfortunate because these POIs could be very important in some situations.

Given the restrictions (particularly around zoom level) of the OSM Carto tiles on osm.org, why not instead use a different rendering that can show these objects?

rbovard commented 5 years ago

@SomeoneElseOSM Do you mean a smaller symbol than the one proposed by @kocio-pl in the first message? Because I already find it discreet and understandable, don't you?

rbovard commented 5 years ago

I just made some visual tests with proposed icon:

Variant A: aed-green

Variant B: aed-red

SomeoneElseOSM commented 5 years ago

For completeness, here's what I use in a different map style - https://map.atownsend.org.uk/maps/map/map.html#zoom=17&lat=54.001639&lon=-1.058 (the purple "AED" in that image). That actually doesn't look too out of place at zoom 17 (it's a deliberately small icon). z19 for comparison: https://map.atownsend.org.uk/maps/map/map.html#zoom=19&lat=54.001784&lon=-1.057609 and z21: https://map.atownsend.org.uk/maps/map/map.html#zoom=21&lat=54.0018778&lon=-1.0575059 .

In your second image above it does look "odd" to have the AED icon the same colour and size as a hospital one. Ultimately every map style needs "guardians" deciding what to leave out - otherwise you'll end up with a complete mess. Any style decisions won't be to everyone's taste since everyone has different requirements and ideas (and certainly numerous decisions here don't fit in with mine!); I was mostly asking about your insistence about adding it to this particular map style, as opposed to (say) one of the other 3 at osm.org or the many, many others that use OSM data.

rbovard commented 5 years ago

Okay, thanks a lot for your example. Is the use of text symbols part of the OSM's best practices for rendering?

And what do you think with smaller icons (sorry for the quality, I'm working with raster images):

Variant C: image

Variant D: image

I was mostly asking about your insistence about adding it to this particular map style, as opposed to (say) one of the other 3 at osm.org or the many, many others that use OSM data.

Because this information can be vital in some cases and the more people know where they are, the more lives could be saved.

And also for the reason that @dktue mentioned:

Because rendering does not only show things for consumers of the map but also encourages mappers to put this type of feature into openstreetmap.

SomeoneElseOSM commented 5 years ago

Okay, thanks a lot for your example. Is the use of text symbols part of the OSM's best practices for rendering?

OSM doesn't have best practices for rendering. This style, as I understand it, doesn't use text unless unavoidable, because it's designed to be an international style for use by people whose native language might use non-latin characters.

rbovard commented 5 years ago

Okay, so if we want to have a chance to see AED landing in default style it's better to use a symbol.

What do you think about my last proposal?

@kocio-pl: Is it possible to reopen this issue, since we are actually trying to figure out how to add these defibrillators on the map?

kocio-pl commented 5 years ago

Sure - the discussion is real, so let's make it visible.

dktue commented 5 years ago

@rbovard : I personally prefer the green version of your icons but that's mostly because in Germany the typical icon for an AED is green.

rbovard commented 5 years ago

As pointed out by @rjw62, I think the universal AED sign is green. [1]

But in OSM, health related points are red. [2]

So the question is, should we fit into health color scheme or create a new one in green? A lot of emergency symbols are green (but not all, eg. fire) [3]

[1] https://www.ilcor.org/home/ (see Universal AED sign at the bottom) [2] https://wiki.openstreetmap.org/wiki/Map_Features#Healthcare [3] Search results emergency green symbol

matkoniecz commented 5 years ago

There are many universal colour systems.

Following all of them for symbols on map, with so huge range of symbols would not end well.

If defibrillator would be rendered it should be rendered in a colour common with other healthcare objects.

rbovard commented 5 years ago

Ok, I totally agree with you.

So we need to propose a red symbol, which is not too big comparing to other healtcare facilites.

I made some tests, this time with vector symbols:

Variant E: export-a

Variant F: export-b

What do you think?

matkoniecz commented 5 years ago

Second icon look like an ice cream cone.

First one is unfortunately not clear - is it possible to make symbol within heart bigger?

(note: I have not thought whatever this object should appear on map, but note that if present it may be hidden by other icons appearing earlier and certainly will not get a special priority in case of multiple icons at one place).

dktue commented 5 years ago

@matkoniecz : For me it was hard to see an ice cream cone -- I could immediately identify the ECG. But I think having the first icon (with a bigger and clearer flash-icon) would be better as it follows more the typical icon for an AED.

rbovard commented 5 years ago

@matkoniecz Thanks for your feedback.

For the variant F, I simply used the defibrillator maki icon [1]

Anyway I tried 2 new variants with a bigger bolt:

Variant G: export-g

Variant H: export-h

[1] https://github.com/mapbox/maki/blob/master/icons/defibrillator-15.svg

rjw62 commented 5 years ago

I think the bolt is more visible on Variant G, and that's my favourite so far. I think the overall icon is still a little on the large side, and it might be more acceptable if it could be slightly smaller. To me the heart shape looks a bit too wide anyway, so I wonder if you could keep the same height and the same bolt inside as Variant G, but reduce the width of the heart outline by one pixel on each side.

rbovard commented 5 years ago

@rjw62 Thanks for your suggestion.

Variant I:

export-i

dktue commented 5 years ago

I prefer the bolt of variant H because its shape is closer to the typical AED-icon. I like the narrower heart of variant I. Maybe you can merge them @rbovard ?