gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.53k stars 817 forks source link

Some shop names still don't render properly #161

Closed RicoElectrico closed 10 years ago

RicoElectrico commented 10 years ago

Specifically, shop=convenience still doesn't have a name rendered (here): dfgdfg

... or it is rendered but without the icon (which in the old stylesheet, was not the case and it should not be as it leads to confusion) - this is what we get at z18 and z17: dfgdfggdf

Another problem here (This may have something to do with the mall being mapped in the indoor mapping scheme which represents shops as areas which can overlap (different levels)):

sddfsdfsdf

tyrasd commented 10 years ago

I'd say this could be the same issue as in #109

gravitystorm commented 10 years ago

@tyrasd almost certainly. The second image shows that when the icon is knocked off, there's space for the label, but not both together.

There's a wider question of preventing "dangling labels", but that might be best for a different issue.

HolgerJeromin commented 10 years ago

The linked examples looks good right now. Close this issue?

matthijsmelissen commented 10 years ago

Closed.

matkoniecz commented 10 years ago

IMHO dangling label is better than nothing, I am not considering it as a problem.