search

gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.53k stars 819 forks source link

render water sport facilities (non waterpark) #2018

Closed HolgerJeromin closed 5 years ago

HolgerJeromin commented 8 years ago

We should render leisure=sports_centre + sport=swimming same as the current leisure=water_park to prevent tagging for the renderer (for not fun orientated water stuff). All keys are available in the database.

The sports_centre + swimming combination is quite often used (Taginfo says 3272) even now.

polarbearing commented 8 years ago

leisure=water_park still lacks area rendering #1490, being a candidate for a new boundary style #1624.

matkoniecz commented 8 years ago

taginfo link: https://taginfo.openstreetmap.org/tags/leisure=sports_centre#combinations (3420 as of 2016-03-04).

ghost commented 6 years ago

@matkoniecz: Here's the link to the discussion on the tagging mailing list about swimming pool facilities: https://lists.openstreetmap.org/pipermail/tagging/2017-September/subject.html#33466.

Copied from #2870:

The result from the discussion on the tagging mailing list is that public indoor as well as outdoor swimming facilities should be tagged leisure=sports_centre + sport=swimming and that leisure=water_park should only be used for real water parks (amusement parks featuring slides, wave pools etc.).

Therefore I think it would be best to use the swimmer icon for leisure=sports_centre + sports=swimming (#2018) and to change the icon for leisure=water_park for a water slide or similar (as one doesn't swim there).

Current use of leisure=sports_centre + sports=swimming: 8 028

geozeisig commented 6 years ago

We have now revised the water sports in the wiki and cleaned up. There are four features that should have an icon:

  1. leisure=water_park has now swimming-16 This is misleading and should be changed. For example, in a water slide or a person in the water playing the ball.

  2. leisure=sports_centre + sport=swimming should have the following icon: swimming-16

  3. leisure=swimming_area + sport=swimming should have the following icon: swimming-16

  4. amenity=public_bath we have now: public_bath that's OK

HolgerJeromin commented 6 years ago
  1. leisure=swimming_area + sport=swimming

Wiki makes the sport tag optional

geozeisig commented 6 years ago

@HolgerJeromin Thanks for the hint. At leisure=swimming_area it is already clear from the word that it is sport=swimming. So I change my suggestion:

  1. leisure=swimming_area should have the following icon: swimming-16
Tomasz-W commented 6 years ago

related to https://github.com/gravitystorm/openstreetmap-carto/issues/844