gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.54k stars 823 forks source link

place=neighbourhood label should not block railway=station label #2211

Open matkoniecz opened 8 years ago

matkoniecz commented 8 years ago

see for example http://www.openstreetmap.org/node/3239135450#map=15/41.8735/-87.6226

selection_013

pnorman commented 8 years ago

I'm not sure. In that case, I'd agree, but if you zoom out and look at http://overpass-turbo.eu/s/h7q might it be the other way around?

I think this is something that needs testing and looking at.

Should this apply for all of 'suburb', 'village', 'hamlet', 'neighbourhood', 'locality', 'isolated_dwelling', 'farm'? If so, the order of placenames-small and stations+stations-poly could be flipped

matkoniecz commented 8 years ago

I'd agree, but if you zoom out and look at http://overpass-turbo.eu/s/h7q might it be the other way around?

In case of Chicago it may be another problem, with subway station displayed as too important.

I was not reporting it due to limited experience with subways - but I suspect that displaying them from z12 (icon)/z14 (label) like normal train stations may be too early.

Also, subway station in theory should be distinguishable with hstore (wiki mentions station=subway but it is unused for at least some subway stations.

In cases of railway stations known to me it would be preferable ti display railway station over minor place labels. Likely conflicts include placenames-medium::medium-importance at z14 and place=village at z14 to z17.

dieterdreist commented 8 years ago

sent from a phone

Il giorno 03 lug 2016, alle ore 23:28, Mateusz Konieczny notifications@github.com ha scritto:

see for example http://www.openstreetmap.org/node/3239135450#map=15/41.8735/-87.6226

for minor stations (light rail, local trains, subways, tram) the neighborhood label seems more important to me, for main stations it might be disputable

Tomasz-W commented 6 years ago

@kocio-pl Example place looks OK at the moment (both neighbourhood and railway station names are displayed normally). Shouldn't this issue be closed then?