gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.52k stars 814 forks source link

Render leisure=resort #2290

Open zlant opened 7 years ago

zlant commented 7 years ago

Render leisure=resort and label. Object for example: http://www.openstreetmap.org/way/290825122 I think the color is set like a tourism=camp_site (@campsite: #def6c0;)

pnorman commented 7 years ago

notes from taginfo

1.5k uses, usage is not worldwide image

jojo4u commented 7 years ago

The wiki article created in 2015 is ok There was no proposal but some discussion in 2013. The nearly empty article tourism=resort should probably point to this tag.

d1g commented 7 years ago

RU:Tag:leisure=resort provides more information about additional sub classes. We would tag these objects, as they were requested by users (pre Oct 2015) and still functional. The only question is uniform tagging.

Most of them have nothing to do with hotels/motels/hostels, in sense you wouldn't visit leisure=resort + resort=kids_camp as adult, unless your children attended there.

You wouldn't visit other leisure objects unless your are ill/old/other reason irrelevant to an ordinary/adult tourism and so on.

re @pnorman I don't think that mostly outdoor facilities dedicated to children resorts leisure=resort + resort=kids_camp ("детский лагерь") can have global coverage. Not many countries make such distinction, am I wrong?

Wikipedia says that they are present at least in some other countries: https://en.wikipedia.org/wiki/Summer_camp#Around_the_world but are they used?

In Canada, summer camps are very popular. About 70% of Canadian camps tend to be affiliated with organizations, while the rest are private.

The American Camp Association (ACA) reports that there are about 7,000 overnight camps and about 5,000 day camps in the U.S., for a total of more than 12,000 camps.

pnorman commented 7 years ago

They're present around the world and used, but leisure=resort is mainly used in one area.

kocio-pl commented 6 years ago

They are concentrated around Europe, but they are also tagged all around the world, so it looks OK for me. I would render them just like other leisure/sport areas.

polarbearing commented 6 years ago

I'd see them more tourism-oriented, thus looking towards camp-sites as in the first post might be better than leisure/sport which is more everyday activities.

We could also go a step forward and consider all campuses for touristic accommodation, hotel, resort, hostel etc, see #1624 (accommodation).

I'd imagine a blue outline (similar to the brown for theme_parks)

kocio-pl commented 6 years ago

Makes sense for me.

polarbearing commented 6 years ago

Here are some experiments, using the code for theme_park in the blue from accommodation icons. Current (has recreation_ground and barrier): current Blue outline, recreation_ground and barrier on: rec-ground_on Blue outline, recreation_ground off, and barrier on: rec-ground-off Blue outline, recreation_ground off, and barrier really off: fence-off2

I don't see a difference with barrier on or off, maybe the outline covers the barrier line? edit: Barrier was not fully switched off. Fixed.

Conflicts with maritime features need to be checked.

kocio-pl commented 6 years ago

It looks interesting, it's worth checking.

polarbearing commented 6 years ago

leisure=marina comes into mind, however it encloses a water body, and it is a different blue leisure-marina There seems to be no specific rendering of general harbours.

kocio-pl commented 6 years ago

For me this is different enough.

polarbearing commented 6 years ago

Ok, so should we apply this to all campuses of

kocio-pl commented 6 years ago

I think yes in general.

I don't see a difference with barrier on or off, maybe the outline covers the barrier line?

We should check it with zoo, probably this problem is there already.

polarbearing commented 6 years ago

Code seems fine, I made some code tests with thick red fences. However the red blends with the tourism or accommodation colour. This is the same if I put the outline code before or after the barrier code, despite only the outline has opacity? Shouldn't the solid red paint clearly over, or would that have to be in a different file? Anyway, so the normal 0.4 grey fences are probably just too weak in the outline to be visible. red-fence-over-tourism-boundaryred-fence-over-accommodation-boundary

polarbearing commented 6 years ago

I learnt that in the earlier tests, barrier was not really off, since the fence being a closed line, when the object also has an area (landuse?) tag, becomes an area_barrier. There is a subtle difference now visible in the with/without barrier comparison.

Since the outline code uses opacity, we get a few blending effects so that needs to be tested with different landuse backgrounds.

kocio-pl commented 6 years ago

I'm not sure if we need two lines in the first place. I guess they are good for really big areas, where you want to know what is inside and what is outside (like natural parks), but accommodation areas should be much smaller and light blue (even thinner than currently) could be enough.

polarbearing commented 6 years ago

Only one line, width=2, no opacity (avoids problems with changing landuse like commercial etc): z16 z16-2px z16-2px-rec-gnd z18 z18-2px

polarbearing commented 6 years ago

And brown for museums: (z18 width=2 amenity-brown) z18-museum-2px-brown

kocio-pl commented 6 years ago

Both are looking very nice for me. Things to check and decide:

  1. What about the barrier visibility?
  2. How do they compare to the river/stream and track (with tracktype=grade1) respectively?
kocio-pl commented 6 years ago

I think tourism=resort shouldn't be included, because both leisure=resort and leisure=beach_resort have more uses and are advised instead on the wiki.

polarbearing commented 6 years ago

Flooding the roads as streams and rivers: z15 z15_streamz15_rivers z17 z17_streamz17_rivers z19 z19_stream z19_rivers

polarbearing commented 6 years ago

Barrier tests, z19 blue line width=2 offset =-1 z19_without_barrier z19_with_barrier

offset=-1.5 improves barrier, but without you see 0.5 width of the landuse behind when no barrier is tagged. z19_without_barrier_offset_-1 5

z19_with_barrier_offset_-1 5

Making the offset conditional on the existence of a barrier might be tricky since only parts of the outline might have a fence.

polarbearing commented 6 years ago

Trying a lighter colour for the outline (as in museum tests). z18, outline colour equals icon colour: z18_transport-icon-color_offset-1 5

z18, outline colour 17% lighter than icon, with barrier: z18_transport-lightercolor_offset-1_barrier

z18, outline colour 17% lighter than icon, without barrier: z18_transport-lightercolor_offset-1_barrier_off

polarbearing commented 6 years ago

So far, barriers were rendered before the tourism outlines. The latter need to be moved up in the project.mml so barriers draw over them. This will improve the current theme_park as well, ill show later. z19_transport-light_barrier_over_outline

ghost07tula commented 5 years ago

As I can see here the use of tag significantly increased worldwide last years. Just compare with one of the first comments on this issue. It seems the time has come to bring leisure=resort into focus.

https://taginfo.openstreetmap.org/tags/leisure=resort#map

kocio-pl commented 5 years ago

The main problem is to design how should it look like - if we have this, focus will follow most probably. :smile:

polarbearing commented 5 years ago

Probably I can come back to the outline tests the following weeks.

EdLoach commented 5 years ago

I suspect usage would be even higher if it rendered - I'm aware of a few places tagged tourism=resort or tourism=attraction where leisure=resort looks like it might be appropriate.

jeisenbe commented 5 years ago

If we pick a new color for accommodation icons, we could use a similar color for the resort outline On Mon, Jan 14, 2019 at 6:49 PM EdLoach notifications@github.com wrote:

I suspect usage would be even higher if it rendered - I'm aware of a few places tagged tourism=resort or tourism=attraction where leisure=resort looks like it might be appropriate.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gravitystorm/openstreetmap-carto/issues/2290#issuecomment-453948568, or mute the thread https://github.com/notifications/unsubscribe-auth/AoxshP2T5TuT0ECN0hhNid_y_uIwFPM7ks5vDFLFgaJpZM4JnJxQ .

polarbearing commented 5 years ago

Yes of course, that's the intention.

jidanni commented 5 years ago

https://www.openstreetmap.org/way/562255930 invisible in any layer.

polarbearing commented 5 years ago

Yes, that's why the ticket is still open.

jidanni commented 5 years ago

I'm wondering if the world's largest resorts show up in OSM...

Hmmm, looking at https://www.touristmaker.com/blog/the-largest-resorts-in-the-world/ they mean resort towns.

https://www.cntraveler.com/gallery/best-resorts-in-the-world are more like the resorts I'm thinking of.

Anyway let's first check if Club Med shows up... https://www.openstreetmap.org/search?query=Club%20Med all not resorts...

matkoniecz commented 5 years ago

Yes, that's why the ticket is still open.

Yes, in general commenting in opened issues (because issue was not yet fixed) that issue remains unfixed is not useful.

openstreetmap.org/way/562255930 invisible in any layer.

Also, in this particular case it seems to be a mistagged feature anyway.

I'm wondering if the world's largest resorts show up in OSM...

I am not sire why you thought that this information is useful at all. leisure=resort is not rendered, so checking it in other places is not going to reveal anything interesting on this topic.

jidanni commented 5 years ago

Also, in this particular case it seems to be a mistagged feature anyway.

OK I retagged it, based on their Facebook category. Thanks.

PontiacCZ commented 4 years ago

Current taginfo for leisure=resort:

Nearly 10K uses.

image

jidanni commented 4 years ago

I wonder if even the most famous are on the map. Trump has one too in Florida...

GunSmoker commented 2 years ago

Can anyone suggest a possible workaround until this is implemented? leisure=resort + landuse=recreation_ground ? Anything at all?

literannn commented 2 years ago

13,7K uses... https://taginfo.openstreetmap.org/search?q=leisure%3Dresort

Maybe it's time to add rendering of leisure=resort to Carto?

ghost07tula commented 2 years ago

Yes, there are a lot of resorts in the database, but they are not rendered still.

vazhnov commented 2 years ago

Let's do it at least in 2022! Before the new summer season came — let's render all resorts…

benoit-dd commented 2 years ago

what's the consensus so far?

what's still to decide?

Personnal comments: I find the blue outline or filling disturbing as it is usally used by water element. Just an outline is fine as it doesn't interfere with landuse (for example some resort are cabins in the woods) I'd go with the same line colour and style as theme_park, but it might be weird if the label+icon and line are not the same color?

For the icon, I'd suggest something with a few houses stacked together image

imagico commented 2 years ago

This is an open discussion - anyone is welcome to present ideas and arguments. But please understand that the presence of certain ideas in the discussion here (or the lack of critique of them) is not an indication of consensus. A decision will only be made based on a concrete pull request.

I have not formed an opinion so far on this - nor do i have a clear understanding of what leisure=resort is de facto used for in OSM. The wiki is decidedly non-helpful on that, it is vague and self contradicting. Pages in different languages indicate that the tag might be used for semantically very different things in different parts of the world.

benoit-dd commented 2 years ago

I didn't intend to stop the discussion, but rather to ask id these two points where indeed consensual and see if it was possible to move to other points that where lacking to be able to make a satsifying pull-request

nc011 commented 2 years ago

I think a quick win here (based on my understanding of what leisure=resort means in OSM) would be to render like a tourism=camp_site but with the tourism=chalet icon instead of the tent.

I think this at least would get this well-used tag rendered and gives at least some idea of what it is.

BertMule commented 1 year ago

I have added the tag to a building, then moved it to a point on the building. Neither were rendered. Purpose was to display the name.

Frustrating, as so often. Please do something with it.

ZLima12 commented 1 year ago

Please don't map for the renderer.

BertMule commented 1 year ago

I map for the users. No rendering = no use.

jeisenbe commented 1 year ago

@BertMule this issue is still open because no one has designed a suitable rendering or submitted a PR (pull request).

All work on this map style is done by unpaid volunteers, and anyone is welcome to submit new rendering ideas and requests.

See https://github.com/gravitystorm/openstreetmap-carto/blob/master/CONTRIBUTING.md for how to contribute a new PR, if you have the time.

tommycrock commented 1 year ago

I have a couple of suggestions for how this could be moved towards an acceptable PR and would appreciate feedback. Although the meaning of resort is broad, it indicates accommodation and leisure facilities. The symbol could be the hotel/motel bed combined with the beach resort parasol. Not all resorts will have parasols but I think it's figurative enough. Alternatively just render a name? These are often quite large areas that currently appear missing, which doesn't help mappers.