gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.55k stars 822 forks source link

Peaks and saddles are hardly visible #2848

Open kocio-pl opened 7 years ago

kocio-pl commented 7 years ago

I guess we could use more vivid orange color for peaks.

Example of multiple peaks in forest:

http://www.openstreetmap.org/#map=13/49.2519/19.8495

but it's also hard to notice on borders, even when orange should give the nice contrast with violet (BTW - South Peak should not eclipse Everest here):

http://www.openstreetmap.org/node/2681940767#map=13/27.9735/86.9301

SomeoneElseOSM commented 7 years ago

Isn't an orangey colour still used for volcanos?

https://www.openstreetmap.org/node/441414522#map=15/37.7565/14.9973

kocio-pl commented 7 years ago

It's rather dark red (I haven't tested if this should be more vivid too). For dark green and dark violet backgrounds light orange (instead of dark orange/brown as currently) might be the best way to go.

pnorman commented 7 years ago

image image

kocio-pl commented 7 years ago

BTW - South Peak should not eclipse Everest here

Maybe we should allow peak names to be rendered at least with SN positions (below by default, but try above if not possible)?

matkoniecz commented 7 years ago

Example of multiple peaks in forest:

For me peaks are well visible there.

Zalitoar commented 6 years ago

Hi! What if the icon would have a white buffer as it's already done with the labels?

kocio-pl commented 6 years ago

Nice idea to test, thanks!

nebulon42 commented 6 years ago

Actually all icons should have a halo like I proposed multiple times already. It does not make sense to do this only for peaks it has to be done for all icons.

kocio-pl commented 6 years ago

That was so long ago that I don't even remember... Could you post some examples? I'm not sure if we lack icons visibility, so I'd like to check if that would really improve the map.

nebulon42 commented 6 years ago

Easy to find: https://github.com/gravitystorm/openstreetmap-carto/issues/1189 https://github.com/gravitystorm/openstreetmap-carto/pull/1341

The reasons to dismiss that were non-reasons to me.

kocio-pl commented 6 years ago

I've been thinking about it. I see no big difference with halo for these icons, but sometimes they look a bit more crisp. Bigger size should not change anything in less filled places, but where there are a lot of icons some of them would be hidden, so it would be OK for me to have less crowded space.

However I have a question - is this possible now to add the halo as a code in MSS or it still needs to be done inside the icons?

nebulon42 commented 6 years ago

I think it still has to be done in the icons.

kocio-pl commented 6 years ago

So we would need a script to add it probably and decide which icons should have this - and which shouldn't maybe.

kocio-pl commented 6 years ago

Saddles suffer the same problem:

screenshot-2018-5-20 openstreetmap

https://www.openstreetmap.org/node/5255771803#map=18/49.41747/21.69598