gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.55k stars 822 forks source link

leisure=garden & leisure=park have the same colour #3022

Closed DaveF63 closed 6 years ago

DaveF63 commented 6 years ago

Public gardens are often sections within parks but atm there's no visible difference: https://www.openstreetmap.org/way/191318876#map=19/51.45508/-2.58866

Slight darker shade or a boundary?

SomeoneElseOSM commented 6 years ago

Example of what a "slightly darker shade" would look like: http://map.atownsend.org.uk/maps/map/map.html#zoom=19&lat=51.455193&lon=-2.589031 (different map style, but parks are the same colour, gardens different).

DaveF63 commented 6 years ago

Is my memory fading or is that the shade OSMCarto rendered gardens until recently?

SomeoneElseOSM commented 6 years ago

It's certainly the shade that OSM Carto rendered gardens in 2014 - I haven't changed it since then.

chrisfleming commented 6 years ago

This was changed quite recently, https://github.com/gravitystorm/openstreetmap-carto/commit/8732cad808b15b6778b03a4089c7fad9d67d1607

I agree Gardens and Parks should be different shades of green, where we've been mapping "private" gardens around houses I think the lurid green looks pretty bad against the buildings and also there is no difference with parks, for example:

https://www.openstreetmap.org/search?query=edinburgh#map=16/55.9398/-3.1911

Cheers Chris

On 14/01/18 at 01:16pm, SomeoneElseOSM wrote:

It's certainly the shade that OSM Carto rendered gardens in 2014 - I haven't changed it since then.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, [1]view it on GitHub, or [2]mute the thread.

Reverse link: [3]unknown

References

Visible links

  1. https://github.com/gravitystorm/openstreetmap-carto/issues/3022#issuecomment-357511232
  2. https://github.com/notifications/unsubscribe-auth/AAOGFAmfkn8b57_Xcc5zD3ix4lxzed36ks5tKf4TgaJpZM4RdllQ
  3. https://github.com/gravitystorm/openstreetmap-carto/issues/3022#issuecomment-357511232
Tomasz-W commented 6 years ago

What do you think about pattern for garden areas: grass green shade with small colorful dots (symbol of flowers) added to it?

DaveF63 commented 6 years ago

What's preventing it returning to it's previous shade, which from memory was the same as @SomeoneElseOSM's current.

I'm not keen on patterned polygons. The translucence of footpaths makes it difficult to see within woods, even when zoomed in.

matthijsmelissen commented 6 years ago

What's preventing it returning to it's previous shade

Before, parks had the same color as grass, so areas of grass in parks were invisible.

dieterdreist commented 6 years ago

just wanted to mention that parks aren't always public, not even in OSM and according to the wiki, and gardens are not always privately owned and might be publicly accessible even if privately owned.

kocio-pl commented 6 years ago

I have introduced this change in #2964.

The problem with garden is that it can be a lot of things - it can be:

So it can be for leisure, decorative or food purposes (maybe some others too). With so much colors used already it's no longer the option to have separate color for every object type, some objects should be grouped. The garden has been clustered with grass areas, which I think is less similar than the park (grass only area vs different plants area).

dieterdreist commented 6 years ago

2018-01-15 17:08 GMT+01:00 kocio-pl notifications@github.com:

I have introduced this change in #2964 https://github.com/gravitystorm/openstreetmap-carto/pull/2964.

The problem with garden is that it can be a lot of things - it can be:

  • basically a public or private park, were you can walk (kind of "Palace Garden" or "Botanical Garden"),
  • small decorative area in the public place (similar to flower bed, but filled with other plants)
  • private green area at the backyard of the house, which is not just a lawn (so called back garden https://en.wikipedia.org/wiki/Back_garden ),
  • kind of food garden (thus similar to farmland).

So it can be for leisure, decorative or food purposes (maybe some others too). With so much colors used already it's no longer the option to have separate color for every object type, some objects should be grouped. The garden has been clustered with grass areas, which I think is less similar than the park (grass only area vs different plants area).

yes, there are different styles and kinds of gardens. Typically, I'd see a garden as more intensively cared for (requiring more care), than a park (yes, someone will now post a pic of his garden which he didn't care for in the last 30 years, telling me he wants it exactly like this).

For the record: there are subtags for distinguishing different aspects and types of gardens, and if this style would render some of them differently I am sure, people would use them even more: https://wiki.openstreetmap.org/wiki/Proposed_features/Garden_specification

chrisfleming commented 6 years ago

FYI - I grabbed this screenshot when the changes to the garden colour rolled out. (The top is the new colour and the bottom half the old)

screenshot-2017-12-18 openstreetmap

My main issue is that I don't actually like the new colour and I do agree that we can't have a different colour for everything.

However I do like to be able to see the difference, partly because there are so many Pokemon go players changing Gardens to Parks, and also because I think it's good to see a difference between the largely public park areas's and the largely private gardens. And I think gardens can be summarised as cultivated in some ways and parks which are overall large grass areas.

kocio-pl commented 6 years ago

@dieterdreist Thanks, I was not aware of it! garden:type is being massively used (37k+), however we should look closer if it's clear enough and how should they be rendered then.

kocio-pl commented 6 years ago

Quick and dirty review:

I guess park and big walkable gardens are similar, small residential gardens might be rendered different (how? just like the lawn?) and food garden, if we can identify it, might be rendered different (like a farmland maybe?).

DaveF63 commented 6 years ago

So it can be for leisure, decorative or food purposes (maybe some others too)...

Unless OSMCarto is using sub-tags to differentiate 'leisure=garden' I'm unsure how the multiple ways it's used in OSM is relevant. OSMCarto needs to ensure it doesn't clash with other entities it's gets added on top of.

kocio-pl commented 6 years ago

We are capable of using sub tags, so this is not a problem. Still we need to decide which ones are really useful and how should each type of garden be rendered. What are your propositions and remarks about garden:type for example?

There can be all the combinations - I have seen garden in the park, but also grass in the garden or park, I haven't seen garden in the grass area, but it's possible too... So I guess it won't help us to decide.

dieterdreist commented 6 years ago

2018-01-15 17:49 GMT+01:00 kocio-pl notifications@github.com:

Quick and dirty review:

  • botanical- very close to a park, so should be rendered the same as parks, so no change

no way, it is very different from a park (IMHO), it's a place of conservation and study, no leaving of the paths, etc.

  • residential - most of the time it will be probably "front yard/back garden", I'm not sure how should they be rendered like, but they are not for walking. But residence can be also a manor or palace and the garden can be more similar to park then.
  • community - I don't recognize this type at all just reading definition.
  • castle - definition not presented, probably something similar to manor/palace, but narrow - probably it would be good to have a single tag for all of them (or some hint should be added to wiki pages to simply tag them as parks).

+1, I could maybe imagine having a type like "stately", which is distinguished from "ordinary residential" gardens, but "castle" doesn't seem helpful as a term here (and is ambiguous as well).

  • monastery - most probably a food garden, but may have walking space
  • I don't know.

IMHO ok to have this, although I would expect a monastery to have different garden zones, from decorational to useful (vegetables and salad, herbs and spices, orchard, etc.)

kocio-pl commented 6 years ago

no way, it is very different from a park (IMHO), it's a place of conservation and study, no leaving of the paths, etc.

In the parks I know leaving the paths is not allowed (I know UK might be different, but that's how it is in Poland). In general they are walkable and this is the main similarity. Botanical gardens in Warsaw I know are meant for public just like a park, this is not contradicting scientific use.

dieterdreist commented 6 years ago

2018-01-15 18:17 GMT+01:00 kocio-pl notifications@github.com:

no way, it is very different from a park (IMHO), it's a place of conservation and study, no leaving of the paths, etc.

In the parks I know leaving the paths is not allowed (I know UK might be different, but that's how it is in Poland). In general they are walkable and this is the main similarity. Botanical gardens in Warsaw I know are meant for public just like a park, this is not contradicting scientific use.

yes, all botanical gardens I know are open to the public. The difference to a park is that usually they impose more strict behavioural rules, often require an entrance fee, typically have strict and not so long opening hours., Cycling is usually not allowed, usually there are also indoor areas, a lot of surface is intensively cared for (as opposed to parks where most of the area is typically lawn) etc.

DaveF63 commented 6 years ago

Sorry, I didn't see your previous post until I sent my last one. Unaware garden:type was in use. It would certainly help differentiate when overlaid. botanicaland residential would definitely be beneficial. I've tagged what described as community as allotments as they've been 'alloted' from public land & often have vegetables as well as flora.

The example I gave in my OP isn't really described.

From my experience: botanicaland community & the one in my OP need to be a different shade to park

residentialwon't coincide with parkso could be the same shade if required

Here's a Google 360 of another example of a garden with a park: http://tinyurl.com/y77u6h4w

imagico commented 6 years ago

For better understanding:

As usual i would suggest to look at:

dieterdreist commented 6 years ago

2018-01-15 18:34 GMT+01:00 Christoph Hormann notifications@github.com:

For better understanding:

  • leisure=park in OSM is an urban/near-urban area dedicated at a wide range of leisure/recreation activities (unless it is abused by some native English speakers for anything named park)

this really depends on the context, in some cases the park is dedicated to a very narrow range of leisure activities (go for a walk, but not cycling, not leaving the path).

kocio-pl commented 6 years ago

@dieterdreist

In the parks I know cycling is also not allowed, some of them require fee and some are fenced.

However making the list "gardens vs parks" is not our ultimate goal - of course we may find differences between types, but the real problem is how should gardens be rendered? There will be always differences between objects in a "cluster", but we need to find patterns of similarities.

In other words: which clusters do you propose - and how should they be rendered?

@imagico

For better understanding:

This sounds like a clear difference, but I'm afraid it may be not very helpful. Gardening and leisure is where parks and gardens are similar in many cases (parks might not be about plants gardening, but I haven't seen it yet). And leisure is a common back garden purpose, just like food production, depending on the part of the world.

unless it is abused by some native English speakers for anything named park

Some "national parks" are good example (look at the California). However that seems to be true for gardens too, that's why I think big residential gardens (like "Royal Garden") might be just tagged as parks. And this is the same common problem in Polish.

As usual i would suggest to look at:

You're great at analysis, could you make such worldwide research? My research was not based only on my home town, but this is not what I do the best.

dieterdreist commented 6 years ago

2018-01-15 19:11 GMT+01:00 kocio-pl notifications@github.com:

@dieterdreist https://github.com/dieterdreist

In the parks I know cycling is also not allowed, some of them require fee and some are fenced.

However making the list "gardens vs parks" is not our ultimate goal - of course we may find differences between types, but the real problem is how should gardens be rendered?

I agree it depends completely on the type of garden. I would expect

  1. a botanical garden to be different from a park, but similar, e.g. like zoos. 1b Also "rosarium" would be a similar "feature" garden, flower beds, etc.

  2. allotments are probably the same as or similar to "community" gardens (unsure on this, the communities are often quite different kind of people, so maybe it makes to map less usefull not to distinguish), a set of smaller gardens forming an unit and not surrounding a residence).

  3. Stately gardens (or castle, royal, villa, etc.) as well as monastery gardens and residential gardens could make a class of gardens serving a residence (and could be seen as less interesting for the general public from first to last, i.e. stately most intense colour, residential least).

matthijsmelissen commented 6 years ago

Would giving gardens an outline solve this issue?

kocio-pl commented 6 years ago

It would make the small ones (like backyard gardens or flower-bed alike) look worse, so at least not in general.

Tomasz-W commented 6 years ago

I've made few mock-ups in Photoshop (I'm unable to do a test rendering). Grass green shade with colorful dots on it (click for full-size!)

Example1 (25%) klasztor25 Example1 (50%) klasztor50 Example2 (25%) malta25 Example2 (50%) malta50 Pattern (50%) pattern50

Note, that it's very first version, just for show you the idea.

kocio-pl commented 6 years ago

Interesting, we could use some patterns (rather monochrome, I guess) with light green too. Maybe that would be good for all the gardens that are not similar to parks (which maybe should be just tagged like a park).

Tomasz-W commented 6 years ago

I'll try version with green and red dots (like roses). @kocio-pl What about dots size and space beetween them, are they ok?

kocio-pl commented 6 years ago

I don't know, since I'm busy with other things and only try to figure out what could work, but I would start with the orchard pattern probably - it should be regular, because gardening is a human activity and also because orchard is just a special kind of garden in fact.

It would be interesting how would grass areas look inside the garden then.

kocio-pl commented 6 years ago

This idea seems to be general enough - we don't need to look at garden subtypes, which are not that clear it seems, so I like it even more.

If we only add a note in the wiki to treat mainly "walkable" gardens as parks (not every park have to be garden with plants, but all the parks I know are in fact "walkable gardens"), no matter if the name includes Garden/Jardin/Ogród/... etc., that would be enough probably to render everything good.

kocio-pl commented 6 years ago

Well mapped botanical garden for testing how the new look will work with different types of sub-areas:

https://www.openstreetmap.org/way/26633037

dieterdreist commented 6 years ago

2018-01-22 19:32 GMT+01:00 kocio-pl notifications@github.com:

Well mapped botanical garden for testing how the new look will work with different types of sub-areas:

https://www.openstreetmap.org/way/26633037

another one in Berlin: https://www.openstreetmap.org/way/125194752 another one with different tagging: https://www.openstreetmap.org/way/26481293

kocio-pl commented 6 years ago

The first one is interesting because it has an orchard inside.

The second one should have probably operator defined instead of amenity=university. But what are really these parts? - like that:

https://www.openstreetmap.org/way/226294581

Currently I think botanical gardens (leisure=garden + garden:type=botanical) might be the only gardens that should be rendered like a park.

dieterdreist commented 6 years ago

2018-01-22 19:49 GMT+01:00 kocio-pl notifications@github.com:

The second one should have probably operator defined instead of amenity=university.

it is part of the university though

kocio-pl commented 6 years ago

I tag the general campus this way, but not specific types of objects, for example garden of Warsaw University I tag as a garden (adding operator there would be good):

https://www.openstreetmap.org/way/5081150

I think this is the case when both tagging has its merits, so we can choose what looks better - it's not bad data. I would argue that operator has a bit more sense.

dieterdreist commented 6 years ago

2018-01-22 21:11 GMT+01:00 kocio-pl notifications@github.com:

I tag the general campus this way, but not specific types of objects, for example garden of Warsaw University I tag as a garden (adding operator there would be good):

https://www.openstreetmap.org/way/5081150

in the case of Tübingen, the botanical garden is part of the "campus" (actually, it is not a campus university I think) https://www.uni-tuebingen.de/einrichtungen/zentrale-einrichtungen/botanischer-garten.html

kocio-pl commented 6 years ago

I don't see any educational buildings there, so I wouldn't call it campus - just some garden which is university property (school can be owned by church, but I tag it as a school then). The same is true for BG of Warsaw University:

http://www.ogrod.uw.edu.pl/en

However I added university tag for the rest of the area, where there are no more specific landuse than just general university:

https://www.openstreetmap.org/way/25748407

But this is ambiguous question. The only important thing in this ticket is that in current state it probably won't work as a testbed for garden rendering.

dieterdreist commented 6 years ago

sent from a phone

On 22. Jan 2018, at 21:26, kocio-pl notifications@github.com wrote:

I don't see any educational buildings

if we continue, this should better go to the tagging ml ;-). Universities usually do research and education. AFAIK in the botanical garden both is done.

kocio-pl commented 6 years ago

Another idea might be different shade of green, since we have a lot of them they work surprisingly well. One possible way might be to take green from camping site, which has different shade already, since we try to design outline for accommodation areas anyway (see #2290).

Tomasz-W commented 6 years ago

I've made new version of pattern with regular red and dark green dots: pattern red

Examples (still just a Photoshop mock-ups, click for full-scale): bloki klasztor malta ue

polarbearing commented 6 years ago

The red dots are a bit noisy for me, even if they are roses :-)

What about a shape, like a flower with petals flower1, rendered in a light-grey pattern such as forest trees?

kocio-pl commented 6 years ago

After some time off, I think now that we should use just another kind of green for gardens. They can be very different in size, access and purpose, for example:

Flower pattern is appropriate just for some forms of the garden, dots (colorful or just black in rows) might be good for more types, but they suggest growing plants (which sounds to me like most important feature of gardens in general), which might be not proper for zen garden (very few plants) or small residential garden (mainly grass).

So I guess we should use just another green shade, which is similar to grass, but maybe 10% lighter (or start with tourism=camp_site backbround, or maybe mix of grass and park colors), so we can show the structure if there are grass patches inside, but stay generic enough. We could also use dotted version as a generic pattern, so people will add more specific tags (type/style) which contain no dots - it's always better to have more specific tagging so generic values might have some annoyances/ambiguity.

What do you think about it?

Tomasz-W commented 6 years ago

We could also use dotted version as a generic pattern, so people will add more specific tags (type/style) which contain no dots

I like this idea. because most of gardens contains plants, so we should be more focused on them than on the less popular types. What should be this pattern like then? What colours? With dots or some shape?

kocio-pl commented 6 years ago

I think black orchard pattern (with a different green shade in the background) would be good.

Tomasz-W commented 6 years ago

I don't like the idea of adding new shade of green, bacause I think we have them too much now, and adding next one will made mess even worst.

Look at this: https://www.openstreetmap.org/#map=18/52.40511/16.97364 or this: https://www.openstreetmap.org/#map=18/52.41408/16.93156

I think we shoud look for ways to reduce amount of green shades, not add new ones. That's the reason why I proposed dotted pattern with current grass-green background. I also would like to distunguish grasses and meadows in the future, so make two patterns based on grass-green would be good solution here, I think, because all those vegetation areas (grasses, gardens, meadows) are on similar level (height).

kocio-pl commented 6 years ago

I'm quite surprised how well many shades of green work and how easy it's for me to recognize them. For me both examples work good.

Testing with grass color and orchard pattern looks OK for me for big areas and small patches of plants: a4gamn0r bvk2sji8 in uvomu pu5jxsex

I was worried about small residential gardens, but that is also quite OK: sbto5sxw

Orchard for comparison: 1b_nllh_

The only thing that would be not good probably are grass areas inside the garden. I haven't found such place, but this is similar one, where grass and garden are near each other: 50qkyk7w

Tomasz-W commented 6 years ago

2 remarks:

kocio-pl commented 6 years ago

So let the others speak about the colors, please.

We use the crossed pattern for plant_nursery currently (which is also dark green, like an orchard): 46mgszgb

but if that's OK for the others, we can use this one instead - it is denser, so the difference with grass will be more visible: pjgjjfpq hkjjcmmq 96n6tv7s fugmp8aw

daganzdaanda commented 6 years ago

IMHO the coloured patterns are drawing too much attention to themselves, even when the opacity is low.

I believe patterns should be used sparingly, and always be as subtle as possible, because they always raise the noise level. The plant-nursery pattern example is still too dark for my taste. It should have even less contrast to the background. Maybe 40% opacity is enough to make it visible but not irritating?

kocio-pl commented 6 years ago

Could you provide such file? I have problems with processing opacity.