gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.55k stars 822 forks source link

Multipolygon relations: All borders should be labeled #3152

Closed gpsvisualizer closed 5 years ago

gpsvisualizer commented 6 years ago

If a multipolygon relation includes multiple discrete parcels of land, the name of the relation is ONLY drawn around the borders of the largest parcel. This is confusing in situations where some of the land might be far out of view of the biggest chunk.

I supposed I can understand why only one "area label" is drawn per relation; it might look weird if there were fifty parcels visible, all with the same label... but I think the borders, which only appear when zoomed in, should be labeled on every parcel.

multipolygon rendering annotated

Attached file comes from here: https://www.openstreetmap.org/#map=15/45.7934/-121.6350

matkoniecz commented 6 years ago

From what I see it is partially opposite to #59 (see https://github.com/gravitystorm/openstreetmap-carto/issues/59#issuecomment-225128125 )

gpsvisualizer commented 6 years ago

Not exactly. #59 is about whether or not to label each AREA that is part of a multipolygon; I agree that only one area label is best.

Here, I'm asking for the BORDERS to be labeled on all of the areas. This is something that only happens at high zoom levels, and there's no reason it should be restricted to one area per relation.

chazanov commented 6 years ago

What about making the rendering size-dependent? Some US national forest have of dozens of separate areas.

gpsvisualizer commented 6 years ago

Again, I'm not talking about the area labels, I'm talking about the small text that flows along the borders -- text which is ONLY visible at high zoom levels. Even if a forest has dozens or separate areas, all of those areas should have their borders labeled when zoomed in.

chazanov commented 6 years ago

It begins to show up at z=15. So let's just try it!

gpsvisualizer commented 5 years ago

This is still a problem. Any hope of a solution?

jeisenbe commented 5 years ago

text-largest-bbox-only: false; tells Mapnik to render a text label in all of the polygons that are part of a multipolygon. I've tested it:

z13 Before: national-park-multipolygon-test-before

z13 After: z13-national-parks-multipolygon-test-after

jeisenbe commented 5 years ago

It looks like this same problem happens with administrative boundaries too, at least in my test environment.

Are there any other types of multipolygons that have text labels on their borders, besides administrative, nature_reserve, national_park and protected_area?

Before province-multipolygon-test-before

After province-multipolygon-test-after

gpsvisualizer commented 5 years ago

Does your quick-'n'-easy solution cause an AREA label to appear in all of the sub-polygons too? Because I think that issue was more up for debate than just the edge labels... I think it'd be best to stick with labeling just the edges for now.

jeisenbe commented 5 years ago

Does your quick-'n'-easy solution cause an AREA label to appear in all of the sub-polygons too?

No, this only affects the admin-text and nature-reserve-text layers On Sat, Jan 19, 2019 at 4:00 AM GPS Visualizer notifications@github.com wrote:

Does your quick-'n'-easy solution cause an AREA label to appear in all of the sub-polygons too? Because I think that issue was more up for debate than just the edge labels... I think it'd be best to stick with labeling just the edges for now.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/gravitystorm/openstreetmap-carto/issues/3152#issuecomment-455652122, or mute the thread https://github.com/notifications/unsubscribe-auth/AoxshN5yHGK2Vzz_xpyGNi5YXKQmHSlFks5vEhnTgaJpZM4S_l0F .

gpsvisualizer commented 5 years ago

So can you make it happen for real?

gpsvisualizer commented 5 years ago

Hallelujah. Looks like you solved multiple problems. I look forward to it going live.