search

gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.53k stars 819 forks source link

Addresses should have higher priority than storage tanks #3435

Open jidanni opened 5 years ago

jidanni commented 5 years ago

Addresses should cover storage tanks, just like they cover buildings. Not the other way around. #3429

jidanni commented 5 years ago

If addresses didn't cover buildings there would be no addresses.

kocio-pl commented 5 years ago

Hi again:

  1. What is so special about storage tanks which does not apply to many other icons?
  2. How would you like to achieve that?
jidanni commented 5 years ago

So if a building has a tank on its roof or side, its address gets eaten. Preposterous.

jidanni commented 5 years ago

How about solar panels or fish tanks on the roof? Install them and ambulance services can no longer find your house!

kocio-pl commented 5 years ago

We simply don't show them, so it's not a problem.

Special services need more data sources or at least their own server. I know that Polish fire and rescue services use it like this, here's a detailed presentation in Polish (I hope YT will enable automatic translation):

https://youtu.be/etFl6e7Ew00?t=3132

or at least something less sophisticated, like this:

https://wiki.openstreetmap.org/wiki/OpenFireMap

jidanni commented 5 years ago

Fine, all the Whitehouse or Empire State Building has to do is install a water tank and its address disappears. Google should work that way too, I suppose.

jidanni commented 5 years ago

Or even Trump Towers' neighbor pop stand pop tank "trumps" Trump Towers' address!

HolgerJeromin commented 5 years ago

This is the same with all poi in and on buildings:

https://www.openstreetmap.org/?mlat=50.78733&mlon=6.07165#map=19/50.78733/6.07165

Instead of the important building name we see the name of the student bar and the radio sender.

I dont think we really can solve this overall issue.

HolgerJeromin commented 5 years ago

Install them and ambulance services can no longer find your house!

I really hope an adress search tool (nominatim or osmand) does not skip adresses with a tank on top!

kocio-pl commented 5 years ago

It looks that we already avoid showing all man_made things on the roof (which I did for small towers or chimneys):

https://github.com/gravitystorm/openstreetmap-carto/blob/b4bc6930629f7d8c090faa20b8a81a4a56154097/project.mml#L1492-L1493

For standalone storage tanks I don't think there's solution.

jidanni commented 5 years ago

It may be a volunteer fire department, who have never heard of OSM themselves, relying on screenshots from public reporters.

Anyway in the original case, a 1 ㎡ tank nearby a 30 ㎡ house causes the house number to get zapped, even thought it is the only house in 100 meters.

Just simply first paint the house. Then paint the tank. Then paint the number, with a tiny border, to make sure it contrasts with whatever is piled up below it.

P.S., I hope cell towers are still rendered on top of houses.

kocio-pl commented 5 years ago

It may be a volunteer fire department, who have never heard of OSM themselves, relying on screenshots from public reporters.

Still address search tool works. I feel this example is very far stretched.

Anyway in the original case, a 1 ㎡ tank nearby a 30 ㎡ house causes the house number to get zapped, even thought it is the only house in 100 meters.

Such feature as "nearby" is simply not in our database, we can't use it.

P.S., I hope cell towers are still rendered on top of houses.

Only if there's no location=roof or location=rooftop.

jidanni commented 5 years ago

Nearby: unrelated polygon then. Not even adjacent. Like Netherlands and Luxembourg.

kocio-pl commented 5 years ago

This code does not work like this, we don't check any distances. If you want to understand it better, you might start with reading general informations:

https://wiki.openstreetmap.org/wiki/Standard_tile_layer#Technical_details

kocio-pl commented 5 years ago

There's a proposition to make this icon less solid: https://github.com/gravitystorm/openstreetmap-carto/issues/588#issuecomment-422720615 - that might help.

jidanni commented 5 years ago

I need to have people see the address of this house, "1-3".

They can see it just fine on https://www.openstreetmap.org/way/638198859#map=17/24.18167/120.86520

But zooming in causes a water tank to appear and the address to dissappear https://www.openstreetmap.org/way/638198859#map=18/24.18166/120.86521

Zooming further one now gets two water tanks, and no address. https://www.openstreetmap.org/way/638198859#map=19/24.18166/

I assume any new icons for water tanks will still cover up addresses.

It is a sad day tomorrow as I will be forced to move the tanks away from the building enough to get the address to show.

matkoniecz commented 5 years ago

It is a sad day tomorrow as I will be forced to move the tanks away from the

Threatening to damage correct data is not helpful. See https://wiki.openstreetmap.org/wiki/Tagging_for_the_renderer

See https://help.openstreetmap.org/questions/731/how-can-i-revert-a-changeset and https://wiki.openstreetmap.org/wiki/JOSM/Plugins/Reverter for tools to undo edits like this.

jidanni commented 5 years ago

Well one of them has to be removed soon for repairs anyway. So might as well remove it from the map.

polarbearing commented 5 years ago

@jidanni - could you please understand that OSM is a geo database, which can be used for different purposes. Rendering a map as a feedback loop for the mappers is just one of them. Evaluating the data for search and navigation is another one.

BTW I would consider micromapping a tiny tank of 70cm diameter with 19 nodes a waste of data.

jidanni commented 5 years ago

So do I. That would be due no scale bar available when editing. https://github.com/openstreetmap/iD/issues/5435

matkoniecz commented 5 years ago

Can someone provide a photo of location where this is a problem? I suspect that someone incorrectly tagged something that is not a storage tank.

jidanni commented 5 years ago

Can someone provide a photo of location where this is a problem? I suspect that someone incorrectly tagged something that is not a storage tank.

It's my house. I tagged the storage tank. https://github.com/gravitystorm/openstreetmap-carto/issues/3435#issuecomment-433375142

jidanni commented 5 years ago

Can someone provide a photo of location where this is a problem? I suspect that someone incorrectly tagged something that is not a storage tank.

p_20181102_103115_vhdr_auto-459x816

jeisenbe commented 4 years ago

Related to #3880 - Symbol and icon prioritization. In this case the request is to have addr:housenumber text render at higher priority than man_made=storage_tank icons, while in #3904 it is requested that office= dots and text be rendered with higher priority than addr text.

jidanni commented 3 years ago

A second address has arrived at my house, due to mass import of city data! https://www.openstreetmap.org/node/8535565687 Alas, can you believe it, it also got knocked off the map by a different water tank!

Good thing my other house has no "dangerous water tanks" too nearby. Both its hand edited address and its city import address survived to the renderer. https://www.openstreetmap.org/?mlat=24.18170&mlon=120.86615#map=19/24.18170/120.86615