gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.54k stars 822 forks source link

Update some icons #3449

Closed Tomasz-W closed 5 years ago

Tomasz-W commented 6 years ago

There are disussions about updating some of icons, but as they are going on in closed tickets. I'm opening new one for doing it properly.

(current one: https://github.com/gravitystorm/openstreetmap-carto/blob/master/symbols/amenity/restaurant.svg)

(current one: https://github.com/gravitystorm/openstreetmap-carto/blob/master/symbols/man_made/storage_tank.svg)

(current one: https://github.com/gravitystorm/openstreetmap-carto/blob/master/symbols/shop/art.svg)

kocio-pl commented 6 years ago

Regarding arts_centre - What about white mask (from theater) combined with palette instead of a note?

Tomasz-W commented 6 years ago

@kocio-pl I've tried and it didn't work, but I've made palette + note with bigger outline.

amenity arts_centre2

What do you think?

kocio-pl commented 6 years ago

Yes, I think it might work, I just need some real rendering to make sure.

Tomasz-W commented 6 years ago

Gist link for all icons: https://gist.github.com/Tomasz-W/4ebcb87699e6442d696f9c06ce16c31f

@Adamant36 Can you test them?

Adamant36 commented 6 years ago

@Tomasz-W, sure. I'll do it sometime in the next couple of days.

kocio-pl commented 6 years ago

Great!

I would choose standard fork+knife for restaurants, fork+spoon might be useful in the future for some food-related objects.

jeisenbe commented 6 years ago

FYI, in Asia it is common to use spoons, and sometimes there are forks available, but knives are very rarely used by customers at restaurants.

Fork+Knife is very European / Western

But Google uses 🍴 for restaurants, so I suppose everyone understands this icon. On Sat, Oct 20, 2018 at 12:34 PM kocio-pl notifications@github.com wrote:

Great!

I would choose standard fork+knife for restaurants, fork+spoon might be useful in the future for some food-related objects.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gravitystorm/openstreetmap-carto/issues/3449#issuecomment-431545071, or mute the thread https://github.com/notifications/unsubscribe-auth/AoxshHsMHytsT4YYYRjOKZ2yswIo-JDvks5umpnhgaJpZM4XbF7l .

kocio-pl commented 6 years ago

Thanks for the comment, good to have someone having expertise with Eastern cultures! I would stay with spoon then to have some balance. We use a lot of Western conventions in OSM Carto and current symbol is well known already, so it will be just mirrored.

Jez-C commented 6 years ago

Now carto uses the palette on two icons, I disagree with using it on a third.

I think of arts centres providing teaching (dance/theatre/music/painting) and live performance, so agree with having a combined icon - I suggest a combination of half theatre mask + paint brush?

Tomasz-W commented 6 years ago

I prefer "fork + knife" version, but it's not so important thing for me, so I'll be ok also with "fork + spoon"

@Jez-C Shop palette is in shop-violet, gallery palette is in amenity-brown, and palette in arts centre would be only half-visible, so all of them would be easy distinguishable from each other. I've been trying with "mask + brush" and it didn't work.

jidanni commented 6 years ago

I assume new icons will still cover up addresses. https://github.com/gravitystorm/openstreetmap-carto/issues/3435

matkoniecz commented 6 years ago

I assume new icons will still cover up addresses. #3435

As it is obvious from the title this change is not intended to affect adresses. That is not a reason to mention one specific issue everywhere.

Adamant36 commented 5 years ago

@Tomasz-W, should the icon for arts centre be applied to art shops and galleries also or just arts centre? I don't think art shops would have music, but galleries might.

Tomasz-W commented 5 years ago

@Adamant36 It's just for amenity=arts_centre.

Tomasz-W commented 5 years ago

In the topic about small changes of the icons: don't you think that historic=wayside_shine should be moved to amenity-brown? It usually has religious or/ and cultural values, so filling it with man-made-grey is a little bit like a visual reduction of these values. @kocio-pl @Adamant36 ?

kocio-pl commented 5 years ago

Sorry, I don't follow current discussions, but I thought that objects that are not directly usable and are mainly orientation points should be not brown. I believe most shrines are not "usable" (in a meaning of "interaction"), just like crosses.

Adamant36 commented 5 years ago

@Tomasz-W, thanks. Uuumm I don't know about historic=wayside_shrine being amenity-brown or not. I don't have a good definition of what an amenity is (maybe its a European term?). Let alone what qualifies as man made or not.

I do think if we mix tags with colors from different tags to much it will make things way over complicated in the code though due to the way variables work.

Adamant36 commented 5 years ago

arts centre arts centre restaurant fork and knife restaurant fork and knife restaurant fork and spoon restaurant fork and spoon storage tank v3 storage tank v3

kocio-pl commented 5 years ago

Arts centre looks good with a note, storage tanks are still recognizable for me and spoon version is nice too (knife is great and for the Western culture map I would choose it, but we try to consider other parts of the world if possible).

geostonemarten commented 5 years ago

I prefer "fork + knife" version, but it's not so important thing for me, so I'll be ok also with "fork + spoon"

@Jez-C Shop palette is in shop-violet, gallery palette is in amenity-brown, and palette in arts centre would be only half-visible, so all of them would be easy distinguishable from each other. I've been trying with "mask + brush" and it didn't work.

And why not hand or chopsticks ;-)

Adamant36 commented 5 years ago

@Tomasz-W, are you good with the updated icons/fork and spoon?