gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.54k stars 822 forks source link

Missing Contrast in medium zoom levels #3513

Open dieterdreist opened 6 years ago

dieterdreist commented 6 years ago

Expected behavior

general map that gives indications about the place

Actual behavior

road focused

Links and screenshots illustrating the problem

Here some example comparisons between osm-carto and the geofabrik fork, look how the forests are important to understand the structure of the landscape and how they are missing in current osm-carto, until zoom 13 when they become visible but when the scale is so low that you cannot see the bigger picture any more:

Zoom 8

Zoom 8

Zoom 9

Zoom 9

Zoom 10

Zoom 10

Zoom 11

Zoom 11

Zoom 12

Zoom 12

Zoom 13

Zoom 13

color fading was an interesting experiment, but in the end it seems the results are worse with the fading than without.

kocio-pl commented 6 years ago

My opinion with this experiment is that it works better than other maps. If all the elements are strong, it's making visual mess, especially when the shapes are not simplified and averaged (small elements make noise). In fact we loose some contrast then, because there is less difference between elements (the difference between - say - 10 and 100 is bigger than between 90 and 100).

However fading might be not that fast - it needs some testing to find good balance.

jeisenbe commented 6 years ago

Imagico has shown an alternative where the classes of land use and natural areas are combined, so you have darker green for high vegetation (forest, scrub etc), pale green for low vegetation (heath, grass, pasture...), and gray for developed land (residential thru retail).

By having fewer different colors at the low zoom level the map is more readable, even without fading. On Thu, Nov 15, 2018 at 8:46 PM kocio-pl notifications@github.com wrote:

My opinion with this experiment is that it works better than other maps. If all the elements are strong, it's making visual mess, especially when the shapes are not simplified and averaged (small elements make noise). In fact we loose some contrast then, because there is less difference between elements (the difference between - say - 10 and 100 is bigger than between 90 and 100).

However fading might be not that fast - it needs some testing to find good balance.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gravitystorm/openstreetmap-carto/issues/3513#issuecomment-439013389, or mute the thread https://github.com/notifications/unsubscribe-auth/AoxshOAZ9XuLUg_cS43ISA_b07h7WAZCks5uvVQOgaJpZM4YfhW- .

kocio-pl commented 6 years ago

I don't follow this fork closely, but I like the idea of generalized green for high/medium/low vegetation very much and after merging #3327 we have main green colors the same as in @imagico fork, so we can go further in this direction.

Unfortunately demo map is limited to z9, so we can't see the difference on all the midzoom levels (z10-z11). But I think this still has some visual problems when there are many small patches of green (especially dark green) and some fading might help - Moscow area example:

http://maps.imagico.de/#map=9/55.766/37.711&lang=en&r=osmlz&o=aa&ui=2

screenshot_2018-11-15 imagico de maps 1

It seems however that dark green (for high vegetation) is changed for something lighter, so it needs more attention anyway, but is promising - the same area using (probably) our current forest/wood green without fading (some other colors are not up to date) looks worse:

http://maps.imagico.de/#map=9/55.766/37.711&lang=en&r=osmlz&o=ea&ui=2

screenshot_2018-11-15 imagico de maps 2

Another issue is where to draw the line between showing all greens and generalized vegetation greens, because we still want to show specific green areas from some zoom level.

There are also other changes - motorways are turned into violet ( http://blog.imagico.de/more-new-colors/ ), which was possible after border color change into something else - I like both these changes, but it needs even more testing and separate tickets to discuss them.

jeisenbe commented 5 years ago

FYI, the low-zoom colors on Imagico's alt-colors fork are:

@built-up-lowzoom: #d7d4d3;
@vegetation-tall-lowzoom: #b6dca6;
@vegetation-low-lowzoom: #ddecbd;
@bare_ground-lowzoom: #efe7d9;

Compare to:

@grass: #cdebb0;
@scrub: #b5e3b5;
@forest: #add19e;  
...
@residential: #e0dfdf; 
...
@bare_ground: #eee5dc;

So they are all adjusted compared to the high-zoom colors.

This is based off of the repository on GitHub, https://github.com/imagico/osm-carto-alternative-colors/tree/master

Vegetation-low includes: picnic_site, caravan_site, camp_site, grave_yard, cemetery, park, recreation_ground, dog_park, golf_course, miniature_golf, allotments, farmland, greenhouse_horticulture meadow/grassland/grass, village_green, common, garden, heath, bog, string_bog, wet_meadow, fen, marsh

Vegetation-tall includes: vineyard, orchard, plant_nursery, wood, forest, scrub, swamp

Bare_ground: quarry, landfill, bare_rock, scree, shingle, sand beach, shoal,

Built-up: residential, retail, industrial, commercial, garages, farmyard, railway, construction, brownfield power station/generator/substation hospital, clinic, university, college, school, kindergarten parking, aeroway=apron, aerodrome, highway=services, rest_area railway=station fitness_center, sports_center, stadium, track, pitch

I notice that mangroves were left out; I would probably include these under vegetation_tall, and I would also like to give mangroves the new scrub color as a background, once it is decided.

imagico commented 5 years ago

I notice that mangroves were left out

Mangroves are not rendered with a fill color in either OSM-Carto or ac-style.

jeisenbe commented 5 years ago

Right, I’m suggesting that they could get a fill in the future, similar to swamp.

But many (most?) mangroves are closer to scrub in height, so the color could be the same as that used for scrub; this would also help distinguish swamp and mangroves On Tue, Nov 20, 2018 at 8:28 PM Christoph Hormann notifications@github.com wrote:

I notice that mangroves were left out

Mangroves are not rendered with a fill color in either OSM-Carto or ac-style.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/gravitystorm/openstreetmap-carto/issues/3513#issuecomment-440240640, or mute the thread https://github.com/notifications/unsubscribe-auth/AoxshOoeCCsu1Dtl7MGv9IZQf4fPt8Anks5uw-dFgaJpZM4YfhW- .

jeisenbe commented 5 years ago

Related to #3647

As discussed, the three ways to fix this issue are:

1) Remove the landcover fading, and render all landcovers at full strength up to their new limits (z5 for forest, meadow, scrub, heath, farmland, wetland etc).

2) Change the fading to take place at a higher level, say z7 to z5. This would give the landcover the appearance of "fading out" right before it disappears at z4, which is similar to what is done on some other maps. z8 to z12 would now be in full color.

3) Use a reduced set of colors at low zoom, combining different types of vegetation into high and low vegetation, and showing all developed land the same. We already do the latter at mid-zoom with developed land. This is the method used by @imagico in the alternative-colors branch: eg http://maps.imagico.de/#map=9/55.766/37.711&lang=en&r=osmlz&o=aa&ui=2

Would some examples of 3) at z10 thru z12 be helpful?

kocio-pl commented 5 years ago

I am not sure if combining is what really helps here and if it's needed (it's always better to show the differences by default). I see the difference between forest colors in https://github.com/gravitystorm/openstreetmap-carto/issues/3513#issuecomment-439042799 and this might be more important factor.

Using current OSM Carto color layer (without fading) and Gpicker wood is #ADD19D (close to #ADD19E - maybe some small Firefox display error?):

http://maps.imagico.de/#map=9/55.722/37.672&lang=en&r=osmlz&o=ea&ui=2

while using alternative colors layer it's much better #B6DCA5:

http://maps.imagico.de/#map=9/55.722/37.672&lang=en&r=osmlz&o=aa&ui=2

which seems to be close to the vegetation-tall-lowzoom defined as #b6dca6 here (probably the same small display error in browser):

https://github.com/imagico/osm-carto-alternative-colors/blob/441d59909d3dd548731789fec9d75200ee606023/landcover.mss#L76-L84

I would check first if changing woods/forest color to #b6dca6 is not enough on mid/low zoom and how does it work on high zoom.

imagico commented 5 years ago

Two comments here:

This option is followed by the French branch

The french style is not rendering low zoom landcover with mapnik, it uses a pre-rendered image that is scaled to the zoom level in question:

https://github.com/cquest/osmfr-cartocss/blob/master/osmfr.yml#L84-L90 https://github.com/gravitystorm/openstreetmap-carto/pull/2654#issuecomment-314744738

And the one bit mismatch in colors in the low zoom demo is due to some rounding error in color space conversion in the renderer.

kocio-pl commented 5 years ago

I made some initial preview with rough replacing current forest/woods color with vegetation-tall-lowzoom color value (without tuning anything else, like pattern color or changing heath color) and it still looks interesting to me. What do you think about it as a starting point?

1. The contrast with water is smaller (but still acceptable):

a) low zoom water areas

http://maps.imagico.de/#map=9/62.656/27.482&lang=en&r=osmlz&o=de&ui=2 - before

screenshot_2019-01-24 imagico de maps

http://maps.imagico.de/#map=9/62.656/27.482&lang=en&r=osmlz&o=9e&ui=2 - after

screenshot_2019-01-24 imagico de maps 1

b) high zoom water lines

https://www.openstreetmap.org/#map=15/51.8588/21.3818

Before

screenshot_2019-01-24 openstreetmap carto kosmtik

After

screenshot_2019-01-24 openstreetmap carto kosmtik 1

2. Better contrast with cemetery

Before

screenshot_2019-01-24 openstreetmap carto kosmtik 2

After

screenshot_2019-01-24 openstreetmap carto kosmtik 3

3. Worse contrast with current allotments

https://www.openstreetmap.org/#map=14/52.3007/21.0681

Before

screenshot_2019-01-24 openstreetmap carto kosmtik 4

After

screenshot_2019-01-24 openstreetmap carto kosmtik 5

4. Worse contrast with current scrubs

https://www.openstreetmap.org/#map=17/52.13467/21.08249

Before

screenshot_2019-01-24 openstreetmap carto kosmtik 6

After

screenshot_2019-01-24 openstreetmap carto kosmtik 7

5. Worse contrast with current heath

https://www.openstreetmap.org/#map=17/52.15141/21.25455

Before

screenshot_2019-01-24 openstreetmap carto kosmtik 8

After

screenshot_2019-01-24 openstreetmap carto kosmtik 9

6. Good enough contrast with current grass and farmlands, more balanced for different small vegetation patches

https://www.openstreetmap.org/#map=15/52.0971/21.0927

Before

screenshot_2019-01-24 openstreetmap carto kosmtik 10

After

screenshot_2019-01-24 openstreetmap carto kosmtik 11

7. Less aggressive for parks and residential areas

https://www.openstreetmap.org/#map=16/52.2666/20.9920

Before

screenshot_2019-01-24 openstreetmap carto kosmtik 12

After

screenshot_2019-01-24 openstreetmap carto kosmtik 13

jeisenbe commented 5 years ago

Points 3, 4, and 5 (worse contrast with scrub, heath, allotments) are serious problems.

This is not a problem at mid to low zoom level in the alt-colors branch, where heath and allotments are merged with grass and farmland, and scrub is merged with forest.

On Thu, Jan 24, 2019 at 10:22 AM kocio-pl notifications@github.com wrote:

I made some initial preview with rough replacing current forest/woods color with vegetation-tall-lowzoom color value (without tuning anything else, like pattern color or changing heath color) and it still looks interesting to me. What do you think about it as a starting point?

1. The contrast with water is smaller (but still acceptable):

a) low zoom water areas

http://maps.imagico.de/#map=9/62.656/27.482&lang=en&r=osmlz&o=de&ui=2 - before

[image: screenshot_2019-01-24 imagico de maps] https://user-images.githubusercontent.com/5439713/51646572-622b0080-1f79-11e9-8856-e666b9f92f49.png

http://maps.imagico.de/#map=9/62.656/27.482&lang=en&r=osmlz&o=9e&ui=2 - after

[image: screenshot_2019-01-24 imagico de maps 1] https://user-images.githubusercontent.com/5439713/51646583-740ca380-1f79-11e9-9cff-c30b897e8592.png

b) high zoom water lines

https://www.openstreetmap.org/#map=15/51.8588/21.3818

Before

[image: screenshot_2019-01-24 openstreetmap carto kosmtik] https://user-images.githubusercontent.com/5439713/51646704-fb5a1700-1f79-11e9-832c-653fb5b91968.png

After

[image: screenshot_2019-01-24 openstreetmap carto kosmtik 1] https://user-images.githubusercontent.com/5439713/51646715-01e88e80-1f7a-11e9-92da-c18540b13dd4.png

2. Better contrast with cemetery

Before

[image: screenshot_2019-01-24 openstreetmap carto kosmtik 2] https://user-images.githubusercontent.com/5439713/51646860-a8349400-1f7a-11e9-9a05-05d37364cf30.png

After

[image: screenshot_2019-01-24 openstreetmap carto kosmtik 3] https://user-images.githubusercontent.com/5439713/51646865-aec30b80-1f7a-11e9-81fb-cdbfa4ea6467.png

3. Worse contrast with current allotments

https://www.openstreetmap.org/#map=14/52.3007/21.0681

Before

[image: screenshot_2019-01-24 openstreetmap carto kosmtik 4] https://user-images.githubusercontent.com/5439713/51646968-22651880-1f7b-11e9-9c57-bb849cafd2de.png

After

[image: screenshot_2019-01-24 openstreetmap carto kosmtik 5] https://user-images.githubusercontent.com/5439713/51646970-2729cc80-1f7b-11e9-9672-d15e80636ea5.png

4. Worse contrast with current scrubs

https://www.openstreetmap.org/#map=17/52.13467/21.08249

Before

[image: screenshot_2019-01-24 openstreetmap carto kosmtik 6] https://user-images.githubusercontent.com/5439713/51647111-c2bb3d00-1f7b-11e9-8a92-19b8e9819153.png

After

[image: screenshot_2019-01-24 openstreetmap carto kosmtik 7] https://user-images.githubusercontent.com/5439713/51647118-c8b11e00-1f7b-11e9-93af-c7c85d44c7ad.png

5. Worse contrast with current heath

https://www.openstreetmap.org/#map=17/52.15141/21.25455

Before

[image: screenshot_2019-01-24 openstreetmap carto kosmtik 8] https://user-images.githubusercontent.com/5439713/51647268-6278cb00-1f7c-11e9-92fd-0dcd0434e58d.png

After

[image: screenshot_2019-01-24 openstreetmap carto kosmtik 9] https://user-images.githubusercontent.com/5439713/51647274-66a4e880-1f7c-11e9-8947-4ade30c9a79b.png

6. Good enough contrast with current grass and farmlands, more balanced for different small vegetation patches

https://www.openstreetmap.org/#map=15/52.0971/21.0927

Before

[image: screenshot_2019-01-24 openstreetmap carto kosmtik 10] https://user-images.githubusercontent.com/5439713/51647424-0c585780-1f7d-11e9-8cee-63c0dbe22386.png

After

[image: screenshot_2019-01-24 openstreetmap carto kosmtik 11] https://user-images.githubusercontent.com/5439713/51647430-124e3880-1f7d-11e9-84a3-b3285d72cfbf.png

7. Less aggressive for parks and residential areas

https://www.openstreetmap.org/#map=16/52.2666/20.9920

Before

[image: screenshot_2019-01-24 openstreetmap carto kosmtik 12] https://user-images.githubusercontent.com/5439713/51647666-031bba80-1f7e-11e9-9579-a049b5275658.png

After

[image: screenshot_2019-01-24 openstreetmap carto kosmtik 13] https://user-images.githubusercontent.com/5439713/51647675-09119b80-1f7e-11e9-9220-68f6cd1c268a.png

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/gravitystorm/openstreetmap-carto/issues/3513#issuecomment-457030321, or mute the thread https://github.com/notifications/unsubscribe-auth/AoxshMgV_BN5wUHoo3pH4ha3e92fCz9Yks5vGQrggaJpZM4YfhW- .

Adamant36 commented 5 years ago

I think it looks good. Especially with residential. I don't see the issue with scrub either. Although it could be my monitor. Heath and allotments do look worse though, but its not like those can't be tweaked.

jeisenbe commented 5 years ago

Problem 8.: another issue with#b6dca6 for woodland/forest at high zoom is that orchard/vineyard color is #aedfa3; - these are very similar.

#b6dca6 is Lch(84,32,135) and #aedfa3; is Lch(84,35,138) - so the lightness is identical, the hue is almost the same, and the chroma is very close.

This is probably one of the reasons why @imagico merged the orchard and forest colors at low zoom.

Here's a test rendering of Southern Australia (near Adelaide), where there are many vineyards and some areas of forest:

https://www.openstreetmap.org/#map=12/-34.6493/138.9740 Master (current rendering) z12 z12-s-aus-master

z12 Without fading (also same as alt-colors style landcover at this zoom level) z12-s-aus-nofade

z12 Forest #b6dca6 z12-s-aus-nofade-forest

Master z11 z11-s-aus-master-12 -34 6493 138 9740

z11 Without fading z11-s-aus-nofade

z11 Forest #b6dca6 z11-s-aus-nofade-forest

z11 Alt-colors for landcover

Master z10 z10-s-aus-master

z10 Without fading z10-s-aus-nofade

z10 Forest #b6dca6 z10-s-aus-nofade-forest

z10 Alt-colors for landcover z10-s-aus-altcolors