Render historic=* POI's

ZeiP commented 5 years ago

Tags historic=tank and historic=locomotive are currently not rendered, even though they are significant local landmarks that are also of public interest in the map. Could they, along with other missing historic=* POI's, be rendered either with some kind of generic historic POI icon or a more specific icon?

Tomasz-W commented 5 years ago

They have rather too low usage to consider dedicated rendering (tanks: 174, locomotives: 626). I would map them in combination with tourism=attraction + name=*, then they will be rendered at least as labels like in this museum: https://www.openstreetmap.org//#map=19/52.42047/16.93270

kocio-pl commented 5 years ago

Thanks for the idea. Even the most popular type of such objects, historic=aircraft, still hasn't passed the 2k limit, so I will close it for now, but please let us know if there is more of them.

https://taginfo.openstreetmap.org/tags/historic=aircraft

taghistory 28

ZeiP commented 5 years ago

Is the usage count the only factor used in determining if a type of object should be rendered? These are usually quite visible and unique objects that are by nature low in count, but useful for both navigation and finding interesting POI's nearby. Not rendering them will probably mean that something else less specific is used instead. Could all of the currently unrendered historic=* values be rendered as monuments?

kocio-pl commented 5 years ago

The numbers are just indicators how likely is this tagging to be preferred one. Some numbers will be always low (for example there is not even 1000 countries in the world), but for others we try to wait until more people will invest their time to choose it.

jeisenbe commented 5 years ago

We also have a limited number of active contributors, versus a huge number of database tags which could potentially be rendered. On Tue, Nov 20, 2018 at 6:33 AM kocio-pl notifications@github.com wrote:

The numbers are just indicators how likely is this tagging to be preferred one. Some numbers will be always low (for example there is not even 1000 countries in the world), but for others we try to wait until more people will invest their time to choose it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gravitystorm/openstreetmap-carto/issues/3518#issuecomment-440049085, or mute the thread https://github.com/notifications/unsubscribe-auth/AoxshEPDHDzzzmG7qtTyg3R2yYX7pmuyks5uwyOegaJpZM4Ypm3d .

matkoniecz commented 5 years ago

I would map them in combination with tourism=attraction + name=*

Note that this should be done solely in cases where such objects have their own name and are tourism attractions.

van-de-bugger commented 5 years ago

Even the most popular type of such objects, historic=aircraft, still hasn't passed the 2k limit, so I will close it for now, but please let us know if there is more of them.

There is no many aircrafts/locomotives/tanks because they are not rendered.

For example, in my city many tanks are tagged as historic=memorial. Mappers are result-oriented, they want to see objects on the map immediately, not in distant future.So mappers avoid using historic=tank because such POIs are invisible and useless. Most of the tanks are tagged as historic=memorial except few tanks added by me recently.

The same is about aircraft. Recently I changed historic=memorial to historic=aircraft and was very surprised because POI disappeared from the map.

The same is about locomotives. There is a railroad museum in my city with ~20 locomotives. All the locomotives tagged as historic=memorial, not historic=locomotive. Guess why.

So, if there too small number of locomotives/tanks/aircraft, please render them as some generic symbol (e. g. just a dot). In such a case number of mapped locomotives/tanks/aircraft will grow.

Adamant36 commented 5 years ago

or example, in my city many tanks are tagged as historic=memorial. Mappers are result-oriented, they want to see objects on the map immediately, not in distant future.

It seems as though historic=memorial is the only one out of those with a preset in iD Editor. My guess is that's a huge factor to. People aren't going to tag things with tags that aren't to add and that they don't know exist in the first place. So you should probably see if iD Editor can add them. Otherwise, they will never get used. Support there and in JSOM is a big factor in rendering support also, numbers or not. So without them supporting it, it probably wont be rendered whatever the usage numbers are.

As a qualifier to that, there is preset support in iD Editor for the historic tag, as historic site. Which then leads to the ability to add the other values in a drop down menu. But there is no specific preset for the historic keys and people probably wont add them based on a search a general search for "historic." especially considering it misleading says its for a "site" when a locomotive is an object. Not a site. Just like most people probably don't add parks by searching for "leisure" in iD Editor. They just type in park. Getting that worked out is probably the best first step to this happening.

Ungoose commented 4 years ago

A rendering for tank, cannon, and aircraft, (and probably locomotive) would be welcome indeed. There are many such objects in open-air museum exhibits which are regularly re-tagged as either historic=memorial or tourism=attraction (even though only some of them are) precisely because they are not visible when mapped correctly. And they are definitely of interest to at least some map users. And yes, a preset in iD editor is also a major factor, but a preset alone would not advance the issue nearly as much without a rendering on carto. So, now that

the 2k limit

is passed, maybe @kocio-pl will reconsider?