gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.53k stars 819 forks source link

icon for leisure adult_gaming_centre vs amusement_arcade #3630

Open my-na-me opened 5 years ago

my-na-me commented 5 years ago

Is there any reason why leisuse=amusement_arcade currently has an icon and leisure=adult_gaming_centre hasn't? see wiki's: https://wiki.openstreetmap.org/wiki/Tag:leisure%3Damusement_arcade https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dadult_gaming_centre

According to taginfo actually there are leisure=more adult_gaming_centre items recorded in the osm-db than items for leisure=amusement_arcade https://taginfo.openstreetmap.org/tags/leisure=adult_gaming_centre ~2700 items https://taginfo.openstreetmap.org/tags/leisure=amusement_arcade ~1300 items

Expected behavior

=> to see any icon also for leisure=adult_gaming_centre

Actual behavior

=> icon is available for leisure=amusement_arcade but not for leisure=adult_gaming_centre

Links and screenshots illustrating the problem

=> map examples where leisure=amusement_arcade is used: node item: https://www.openstreetmap.org/node/5951389512 area: https://www.openstreetmap.org/#map=19/52.40869/16.92206

=> map examples where leisure=adult_gaming_centre is used: node item: https://www.openstreetmap.org/node/6153818336 area: https://www.openstreetmap.org/#map=19/53.43320/14.54282

way item: https://www.openstreetmap.org/way/402796805 https://www.openstreetmap.org/#map=19/52.20980/21.01990

Adamant36 commented 5 years ago

It might be worth reading issue #3210. I seem to remember it being proposed there. Although the issue was closed.

jeisenbe commented 5 years ago

Could also consider rendering as a dot and name label, rather than as a specific icon.

Adamant36 commented 4 years ago

Could also consider rendering as a dot and name label, rather than as a specific icon.

Make sense to me. If you want to go that route I could probably do a PR for it.

jeisenbe commented 4 years ago

I would be happy to see a PR. We will find out if the other contributors agree that adding features like this as generic dots and name labels is feasible.

Adamant36 commented 4 years ago

@jeisenbe, why not the same icon as for casinos? Their kind of the same thing. A casino is a type of adult gaming center.

jragusa commented 4 years ago

There is also the icon of shop=video_games as a good candidate.

my-na-me commented 4 years ago

There is also the icon of shop=video_games as a good candidate.

So you are talking about https://wiki.openstreetmap.org/wiki/Tag:shop%3Dvideo_games in leisure green: . Video_games-14-green

Adamant36 commented 4 years ago

I don't think the icon for shop=video_games indicates that it's a gaming place only for adults like dice would. Kids play video games and can go into video game stores. Plus, most adult gaming centers have some form of gambling element don't they?

jeisenbe commented 4 years ago

A casino is a type of adult gaming center.

The definitions in Openstreetmap are not quite the same as the standard US English understanding. An amenity=casino is rendered with an icon of dice, since it has table games like roulette, blackjack, etc, using dice and cards commonly. "A gambling venue with at least one table game (e.g. roulette, blackjack). The presence of a croupier is assumed." - https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dcasino

A leisure=adult_gaming_center usually has just video slot machines: "venues with gambling machines, such as slot machines" - https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dadult_gaming_centre

Reusing the icon for shop=video_games or leisure=amusement_arcade would not work. The icon for amenity=casino also might be misleading

Adamant36 commented 4 years ago

Mini slot machine face icon then? Three clubs or 7s or whatever. Slots

imagico commented 4 years ago

Please keep in mind what i wrote in https://github.com/gravitystorm/openstreetmap-carto/pull/3285#issuecomment-404256515.

my-na-me commented 4 years ago

Mini slot machine face icon then? Three clubs or 7s or whatever.

Your picture looks nice, but for an area of 14x14px it could be maybe hard to recognize after transforming.

Something like this:?

14px slotmaschine

28px slotmaschine28