search

gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.53k stars 819 forks source link

Question: What tags does OSM-Carto use to render boundary=national_park relations in its own rendering? #3633

Closed DaveF63 closed 5 years ago

DaveF63 commented 5 years ago

To check - boundary=national_park relations that are split into several ways: What is the tag requirement to get it to them to render both the boundary line/label when zoomed in & the green fill at low zoom levels:

Is area=yes required?

Are outer roles required if there is no inner?

Is there a rule to render them at different zoom levels depending on area?

Is it the same for other area such as boundary=protected & leisure=nature_reserve?

matkoniecz commented 5 years ago

Is there a rule to render them at different zoom levels depending on area?

Yes.

For other questions - is this attempt to check how things should be tagged?

In this case I would not tag for specific rendering but rather follow established tagging rules. Good start is to use power of great JOSM validator - load affected area or object and run validator. It is likely to report many issues, including ones causing wrong rendering.

JOSM validator is not foolproof but it is quite good (and JOSM developers are great at fixing reported problems).

In case that correctly tagged national park is not rendered - please report this specific problem.

matkoniecz commented 5 years ago

Is area=yes required?

It should not be required.

DaveF63 commented 5 years ago

For other questions - is this attempt to check how things should be tagged?

No. To be clear, my questions were specifically relating to which tags OSM-Carto uses to render solely in its rendering. I've amended the title to clarify.

Yes.

Thanks, that helps me understand.

gpsvisualizer commented 5 years ago

Speaking of national parks and such, does anyone know why parts of Gifford Pinchot National Forest are intermittently rendering as if they were natural=wood? https://www.openstreetmap.org/#map=16/46.7264/-121.8517

screen shot 2019-01-18 at 3 01 07 pm

jeisenbe commented 5 years ago

Have you checked the data? Most likely that section of the National Forest is also tagged with landuse=forest or natural=wood. These tags might be on the relation or a multipolygon, if you don’t seem them on an OSM way On Sat, Jan 19, 2019 at 7:59 AM GPS Visualizer notifications@github.com wrote:

gpsvisualizer commented 5 years ago

Have you checked the data? Most likely that section of the National Forest is also tagged with landuse=forest or natural=wood.

Yeah, I checked closely and didn't see anything weird in the tags. And the green fill is sort of coming and going randomly; at one point, I zoomed in one step and the filled and unfilled areas swapped places. So I checked on here because I thought there might be a weird rendering glitch.

DaveF63 commented 5 years ago

Well, someone removed a forest tag a couple of weeks ago, & there's been a hiccup in the render server, so it might be delayed. However, I'm surprised it renders at all. Is this it's actual boundary? http://tools.geofabrik.de/osmi/?view=areas&lon=-122.39784&lat=46.63525&zoom=12&opacity=1.00

Also, you may want to check out this: http://ra.osmsurround.org/analyzeMap?relationId=8162013

gpsvisualizer commented 5 years ago

However, I'm surprised it renders at all. Is this it's actual boundary? http://tools.geofabrik.de/osmi/?view=areas&lon=-122.39784&lat=46.63525&zoom=12&opacity=1.00

That's part of it, yes. And the "touching rings" are exactly as they should be. We have a lot of checkerboard land ownership in this part of the world.

I guess it is just "hiccups," but I've never seen such a persistent case of them!

jeisenbe commented 5 years ago

Closing, it looks like @DaveF63 had questions answered, but please comment if anything else was missed.